Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add inline virtualtext mode #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mehalter
Copy link

This adds a new inline mode to use the new inline virtual text features of Neovim v0.10 (currently nightly)

2023-05-23_11:45:53_screenshot

@olrtg
Copy link

olrtg commented Jul 5, 2023

Thanks for your contribution.. I'm using your fork already! Is it possible to also add an option to change the location of the virtualtext (start/end of the color)?

@olrtg
Copy link

olrtg commented Jul 5, 2023

image

Also I'm wondering why your virtualtext is separated by one space and mine not 🤔

@mehalter
Copy link
Author

mehalter commented Aug 8, 2023

@olrtg Changing start and end would be a great option! I would want to hear back from the maintainers to see what direction they want to go with these types of options. Sadly I haven't heard anything quite yet, so they might not be interested in this type of feature?

Also for your second comment, I personally changed the virtualtext option that already exists to add a space to make it that way. Basically this PR just adds the ability to enable inlay hints but it piggy backs on the already existing option for setting what the actual virtual text is which in the case of not having inlay hints it shouldn't have a space.

@olrtg
Copy link

olrtg commented Aug 8, 2023

@mehalter Thank you so much for the answer! I didn't realized that there was an option for changing that! Now it's working like yours 🤘🏽 And well, we'll have to patiently wait I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants