Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabufline or nvim-tree does not work properly #32

Closed
ginlov opened this issue Nov 12, 2022 · 6 comments
Closed

tabufline or nvim-tree does not work properly #32

ginlov opened this issue Nov 12, 2022 · 6 comments

Comments

@ginlov
Copy link

ginlov commented Nov 12, 2022 •
edited
Loading

Describe the bug
After upgrade plugins, tabufline or nvim-tree does not work properly. I have just updated all plugins by running :PackerUpdate and new patches create bug about buffer. Specifically, nvim-tree take over the buffer 0, which is an unexpected behavior (see video). Both tabufline and nvim-tree has recent update so i suppose the problem is caused by one of them.

To Reproduce
Steps to reproduce the behavior:

  1. Run nvim
  2. :PackerUpdate
  3. :PackerSync

Expected behavior
Nvim-tree buffer does not affected regular action (may be take buffer 0).

Screenshots

Screen.Recording.2022-11-13.at.00.31.47.mov

Desktop (please complete the following information):

  • MacOs 13.0.1
  • Kitty
  • Neovim 0.8

Additional context
@siduck siduck transferred this issue from NvChad/NvChad Nov 13, 2022
@siduck
Copy link
Member

siduck commented Nov 13, 2022

i think the problem is with this commit 0bc1449

does reverting fix it?

@siduck siduck mentioned this issue Nov 13, 2022
Closed
@siduck
Copy link
Member

siduck commented Nov 13, 2022 •
edited
Loading

@lll9p

image

and output of echo t:bufs

image

@siduck
Copy link
Member

siduck commented Nov 13, 2022

yes reverting fixed that D:

@lll9p
Copy link
Contributor

lll9p commented Nov 13, 2022

@siduck I can confirm this, I'll see how to fix it, then request a pull.

@siduck
Copy link
Member

siduck commented Nov 13, 2022 •
edited
Loading

@siduck I can confirm this, I'll see how to fix it, then request a pull.

Ping me when you PR, I need to get this fixed quick so I could continue with working on nvchads new release

lll9p added a commit to lll9p/ui that referenced this issue Nov 13, 2022
@lll9p
Fix: Incorrectly added invalid buf to vim.t.bufs.
ce98111 
Fix: NvChad#31 NvChad#32 

By adding `isBufValid(args.buf)` to determine if bufs like `nvim-tree` window is valid.
BTW, The determination of whether one new added buf is valid is very complicated and needs to be simplified.
@lll9p lll9p mentioned this issue Nov 13, 2022
Merged
@lll9p
Copy link
Contributor

lll9p commented Nov 13, 2022

@siduck @ginlov @Fabian-programmer I made a PR, LGTM but review is needed and confirm issues resolved.

siduck pushed a commit that referenced this issue Nov 13, 2022
@lll9p
Fix: Incorrectly added invalid buf to vim.t.bufs. (#33)
5b6990f 
Fix: #31 #32 

By adding `isBufValid(args.buf)` to determine if bufs like `nvim-tree` window is valid.
BTW, The determination of whether one new added buf is valid is very complicated and needs to be simplified.
@siduck siduck closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lll9p @ginlov @siduck