Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way display network image #37

Closed
ltype opened this issue Jul 15, 2017 · 2 comments
Closed

Better way display network image #37

ltype opened this issue Jul 15, 2017 · 2 comments
Milestone

Comments

@ltype
Copy link
Member

ltype commented Jul 15, 2017

07-15 09:43:59.919 30023-30023/cat.pantsu.nyaapantsu E/AndroidRuntime: FATAL EXCEPTION: main
Process: cat.pantsu.nyaapantsu, PID: 30023
java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter bitmap
at cat.pantsu.nyaapantsu.helper.ImageGetterAsyncTask.onPostExecute(ImageGetter.kt:0)
at cat.pantsu.nyaapantsu.helper.ImageGetterAsyncTask.onPostExecute(ImageGetter.kt:22)
at android.os.AsyncTask.finish(AsyncTask.java:667)
at android.os.AsyncTask.-wrap1(AsyncTask.java)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:684)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

Should we use Fresco for display network image?

ltype added a commit to ltype/NyaaPantsu-android-app that referenced this issue Jul 15, 2017
@xdk78
Copy link
Contributor

xdk78 commented Jul 15, 2017

We use Glide, it's very good, so maybe we should use Rx Kotlin Instead async task?

@xdk78
Copy link
Contributor

xdk78 commented Jul 15, 2017

Ok, if this working better I trust you

@xdk78 xdk78 closed this as completed Jul 15, 2017
@akuma06 akuma06 added this to the v1.2 milestone Jul 22, 2017
@xdk78 xdk78 mentioned this issue Jul 22, 2017
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants