Torrent Generation on not found error #1600

akuma06 · 2017-09-19T13:15:21Z

As asked in #1517, it allows on-the-fly torrent generation. Since it uses magnet links, it needs some time to connect to peers. So it can't be instant generation, we need the user to wait and try after a minute at least.

Edit: ~~Seems like I can't test the PR on my windows machine because Anacrolyx torrent doesn't want to compile...~~
Edit 2 : Works on windows if you have gcc installed, I used msys2 and its tutorial for that https://github.com/orlp/dev-on-windows/wiki/Installing-GCC--&-MSYS2

As asked in #1517, it allows on-the-fly torrent generation. Since it uses magnet links, it needs some time to connect to peers. So it can't be instant generation, we need the user to wait and try after a minute at least.

Kiloutre · 2017-09-19T15:53:37Z

I have no idea what ewhal exactly did, he didn't even commit the changes here, but torrent file generation is already there and working for seemingly every single torrent
Not sure if done on download.go or if he has a script running somewhere that does it for every one of them though
But dont work on this any more until @ewhal gives clarifications as it's a potential waste of time
(Hence why i closed the issue)

ewhal · 2017-09-20T00:26:02Z

The torrent generation script is shit so this is a very good idea

…into generatetorrent

coveralls · 2017-10-06T18:00:34Z

Coverage remained the same at 39.458% when pulling 4fedc30 on generatetorrent into 67d8492 on dev.

akuma06 · 2017-10-07T15:57:36Z

Si quelqu'un peut tester please =)

Kiloutre · 2017-10-07T17:12:13Z

I tried already yesterday but i get a GCC error when go building

akuma06 · 2017-10-07T17:13:35Z

Yeah it seems anacrolyx doesn't compile on windows. We need someone with linux :/

coveralls · 2017-10-07T17:26:52Z

Coverage remained the same at 39.589% when pulling c6cc047 on generatetorrent into 10a70e1 on dev.

Kiloutre

haven't tested but in case you wanna merge it still

akuma06 · 2017-10-07T17:35:31Z

I don't think we should, it will prevent people to build nyaa on windows :/

akuma06 · 2017-10-07T18:14:17Z

Ok to build on windows you need gcc. I just successfully build with the help of msys2 and this tutorial : https://github.com/orlp/dev-on-windows/wiki/Installing-GCC--&-MSYS2

akuma06 · 2017-10-07T19:41:48Z

Tested on my end and it works

coveralls · 2017-10-07T19:54:59Z

Coverage remained the same at 39.589% when pulling 8f170b3 on generatetorrent into 10a70e1 on dev.

Kiloutre · 2017-10-07T20:26:05Z

controllers/torrent/download.go

 	"github.com/NyaaPantsu/nyaa/utils/format"
 	"github.com/gin-gonic/gin"
 )

 // DownloadTorrent : Controller for downloading a torrent
 func DownloadTorrent(c *gin.Context) {
 	hash := c.Param("hash")
+	messages := msg.GetMessages(c)
+
+	if hash == "" { // if no hash provided, you can't find a torrent in db neither the torrent file


There is no /download/ route, only /download/:hash
If hash is empty then download.go will never get executed in the first place, i think?

You're right but I don't know if we should really not check it.

coveralls · 2017-10-10T06:00:39Z

Coverage decreased (-0.1%) to 39.443% when pulling fea276e on generatetorrent into bad9285 on dev.

akuma06 · 2017-10-11T01:09:17Z

It might be related to windows emulation, it seems the error is windows coroutines related. It would be great to test it on linux :). The easy way to make the error happen is to launch a torrent download and refresh just after before the torrent has been generated.

Kiloutre · 2017-10-11T01:30:51Z

Even if it's windows-specific, pantsu is supposed to be able to be ran on anyone's machine, so it would be nice to get it working on windows as well
~~Besides, i think it worked fine a bunch of commits ago? I'll download an old one and see if it works~~

coveralls · 2017-10-11T01:41:03Z

Coverage decreased (-0.1%) to 39.38% when pulling b4cd6a2 on generatetorrent into 2044a3c on dev.

Kiloutre · 2017-10-11T02:01:35Z

Ran it on dev and it does not seem to work either

akuma06 · 2017-10-11T11:04:42Z

Ok will take a look at it when I have time =)

coveralls · 2017-10-12T03:10:39Z

Coverage decreased (-0.1%) to 39.38% when pulling cfc98ca on generatetorrent into 941aceb on dev.

coveralls · 2017-10-12T03:41:31Z

Coverage decreased (-0.1%) to 39.38% when pulling 447f89e on generatetorrent into 941aceb on dev.

Kiloutre · 2017-10-15T05:28:19Z

no
not working
no merging

not working

coveralls · 2017-10-15T05:37:12Z

Coverage decreased (-0.1%) to 39.358% when pulling edea8a8 on generatetorrent into d3e50b8 on dev.

coveralls · 2017-10-16T03:48:35Z

Coverage decreased (-0.01%) to 39.369% when pulling 4ae6944 on generatetorrent into 2f0e06c on dev.

Seems like this error is a known bug from anacrolyx torrent anacrolix/torrent#83 To prevent it, I'm creating a single client and modifying the socket.go to make it not raise a panic but a simple error log.

coveralls · 2017-10-19T09:47:32Z

Coverage remained the same at 39.38% when pulling ea155e3 on generatetorrent into 2f0e06c on dev.

Kiloutre · 2017-10-19T10:05:10Z

Seems to work, gonna try on linux now

coveralls · 2017-10-19T10:16:31Z

Coverage increased (+0.02%) to 39.38% when pulling a19ddfd on generatetorrent into 33c8303 on dev.

akuma06 · 2017-10-20T14:44:03Z

@Kiloutre ??

Kiloutre

Sry i needed ewhal to test and he simply he isn't there so i couldn't do it
gonna approve anyway so that you can merge if you want

akuma06 added 2 commits September 19, 2017 15:14

[WIP] Torrent Generation on not found error

50d7f35

As asked in #1517, it allows on-the-fly torrent generation. Since it uses magnet links, it needs some time to connect to peers. So it can't be instant generation, we need the user to wait and try after a minute at least.

Replace Fatal by simple error

251ed31

Kiloutre and others added 7 commits October 5, 2017 23:57

attempt at fixing travis

0b25884

del

978abb6

Merge branch 'dev' into generatetorrent

3e74fb3

Merge branch 'dev' into generatetorrent

534f037

Add Anacrolyx dependency

d17b442

Merge branch 'generatetorrent' of https://github.com/NyaaPantsu/nyaa …

de95072

…into generatetorrent

Add back difflib

4fedc30

akuma06 changed the title ~~[WIP] Torrent Generation on not found error~~ Torrent Generation on not found error Oct 7, 2017

Merge branch 'dev' into generatetorrent

c6cc047

Kiloutre previously approved these changes Oct 7, 2017

View reviewed changes

akuma06 added 5 commits October 7, 2017 21:37

Remove .torrent suffix in the url example

8920dea

Add some explanations when file missing page shown

8f2e568

Ignore downloads directory

b866356

Either use cache (third-party site) or own download directory

8341125

Wrong import

8f170b3

akuma06 dismissed Kiloutre’s stale review via 8f170b3 October 7, 2017 19:41

Kiloutre reviewed Oct 7, 2017

View reviewed changes

Merge branch 'dev' into generatetorrent

b4cd6a2

Kiloutre mentioned this pull request Oct 12, 2017

Upload to nyaa.si, anidex & TokyoTosho [done] #1633

Merged

Merge branch 'dev' into generatetorrent

cfc98ca

fix some css rules that didn't work on IE

447f89e

Merge branch 'dev' into generatetorrent

edea8a8

ewhal previously approved these changes Oct 15, 2017

View reviewed changes

Kiloutre changed the title ~~Torrent Generation on not found error~~ [WIP] Torrent Generation on not found error Oct 15, 2017

Merge branch 'dev' into generatetorrent

4ae6944

Fix panic error

ea155e3

Seems like this error is a known bug from anacrolyx torrent anacrolix/torrent#83 To prevent it, I'm creating a single client and modifying the socket.go to make it not raise a panic but a simple error log.

akuma06 changed the title ~~[WIP] Torrent Generation on not found error~~ Torrent Generation on not found error Oct 19, 2017

Merge branch 'dev' into generatetorrent

a19ddfd

Kiloutre approved these changes Oct 20, 2017

View reviewed changes

akuma06 merged commit b2b48f6 into dev Oct 21, 2017

akuma06 deleted the generatetorrent branch October 21, 2017 07:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Torrent Generation on not found error #1600

Torrent Generation on not found error #1600

akuma06 commented Sep 19, 2017 •

edited

Loading

Kiloutre commented Sep 19, 2017 •

edited

Loading

ewhal commented Sep 20, 2017

coveralls commented Oct 6, 2017

akuma06 commented Oct 7, 2017

Kiloutre commented Oct 7, 2017

akuma06 commented Oct 7, 2017

coveralls commented Oct 7, 2017

Kiloutre left a comment

akuma06 commented Oct 7, 2017

akuma06 commented Oct 7, 2017 •

edited

Loading

akuma06 commented Oct 7, 2017

coveralls commented Oct 7, 2017

Kiloutre Oct 7, 2017 •

edited

Loading

akuma06 Oct 7, 2017

Kiloutre Oct 8, 2017

coveralls commented Oct 10, 2017

akuma06 commented Oct 11, 2017

Kiloutre commented Oct 11, 2017 •

edited

Loading

coveralls commented Oct 11, 2017

Kiloutre commented Oct 11, 2017

akuma06 commented Oct 11, 2017

coveralls commented Oct 12, 2017

coveralls commented Oct 12, 2017

Kiloutre commented Oct 15, 2017

coveralls commented Oct 15, 2017

coveralls commented Oct 16, 2017

coveralls commented Oct 19, 2017

Kiloutre commented Oct 19, 2017

coveralls commented Oct 19, 2017

akuma06 commented Oct 20, 2017

Kiloutre left a comment

Torrent Generation on not found error #1600

Torrent Generation on not found error #1600

Conversation

akuma06 commented Sep 19, 2017 • edited Loading

Kiloutre commented Sep 19, 2017 • edited Loading

ewhal commented Sep 20, 2017

coveralls commented Oct 6, 2017

akuma06 commented Oct 7, 2017

Kiloutre commented Oct 7, 2017

akuma06 commented Oct 7, 2017

coveralls commented Oct 7, 2017

Kiloutre left a comment

Choose a reason for hiding this comment

akuma06 commented Oct 7, 2017

akuma06 commented Oct 7, 2017 • edited Loading

akuma06 commented Oct 7, 2017

coveralls commented Oct 7, 2017

Kiloutre Oct 7, 2017 • edited Loading

Choose a reason for hiding this comment

akuma06 Oct 7, 2017

Choose a reason for hiding this comment

Kiloutre Oct 8, 2017

Choose a reason for hiding this comment

coveralls commented Oct 10, 2017

akuma06 commented Oct 11, 2017

Kiloutre commented Oct 11, 2017 • edited Loading

coveralls commented Oct 11, 2017

Kiloutre commented Oct 11, 2017

akuma06 commented Oct 11, 2017

coveralls commented Oct 12, 2017

coveralls commented Oct 12, 2017

Kiloutre commented Oct 15, 2017

coveralls commented Oct 15, 2017

coveralls commented Oct 16, 2017

coveralls commented Oct 19, 2017

Kiloutre commented Oct 19, 2017

coveralls commented Oct 19, 2017

akuma06 commented Oct 20, 2017

Kiloutre left a comment

Choose a reason for hiding this comment

akuma06 commented Sep 19, 2017 •

edited

Loading

Kiloutre commented Sep 19, 2017 •

edited

Loading

akuma06 commented Oct 7, 2017 •

edited

Loading

Kiloutre Oct 7, 2017 •

edited

Loading

Kiloutre commented Oct 11, 2017 •

edited

Loading