Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of notification page, lots of fixes & lots of improvements #1698

Merged
merged 191 commits into from
Nov 2, 2017
Merged

Conversation

Kiloutre
Copy link
Contributor

@Kiloutre Kiloutre commented Oct 28, 2017

New features:

  • Full redesign of notification page, looks much better and clearer
  • Added button to clear only already read notifications
  • Added button to mark every notifications as read
  • Notifications are now shown with their creation date
  • Notification count is now shown in header on user avatar if above 0
  • Allow reports to have messages (60char max)
  • Show number of followers and total uploaded torrents size on user profile (used to be there but had to be removed because it was showing an incorrect count)
  • Added button for admins to nuke all torrent reports

Improvements:

  • Users commenting on their own torrent do not trigger notifications any more
  • If you put an unexisting username in refine, the search will show no result instead of acting like you didn't specify any user
  • Prevent duplicate trackers during torrent creation
  • Possibly fix JS theme toggler not working on the very first click for logged-in users, make the query for non-logged in users less heavy for both the user and server
  • Visual cue for locked torrents
  • Admins modifying an user profile can force an e-mail without requiring validation
  • Disclose that comments support markdown
  • Further small improvements toward spacing in comments
  • Add max-width and reasonable max-height for pictures in comments
  • Small changes to bring the classic theme closer to the nyaa.se's theme
  • During user torrent search, Old nav shows "Browsing X's torrents (Y)", X being the username and Y being the amount of torrents related to X, just like nyaa.se
  • During user torrent search, page title includes the username instead of the usual "Home"
  • Allow anonymous users to do reports, make it so that regular users do not need captcha to report
  • Add a default avatar (when user has no avatar) that can be changed by modifying local pantsu files, default avatar is different for sukebei
  • Remove formatDateRFC() function that became useless when i made the formatDate() function
  • Fix the template_test_function part of some functions that was nowhere near proper
  • Rename three functions that had my name in it, remove duplicate functions
  • Announcements duration is now set as hours and not days

Fixes:

  • Fix notification count in header requiring another refresh to update when accessing the torrent the notification is from
  • Fix report deletion that did not work period for admins
  • Fix visual artifact on the "More" links in admin panel, caused by the fact that the link was part of an html list
  • Fix translation strings in admin panels that did not work because of extra spaces
  • Fix unwanted background color on old navigation under sukebei's /g/ theme
  • Fix file list indent not working for folders
  • Fix some user settings requiring a second page refresh to update the changes in the form, not all of them however
  • Fix wrong URL for lock button in admin panel
  • Fix remake & anonymous button that didn't stay checked on upload fail
  • Fix HTML error in old navigation and in torrent comments
  • Fix announcement deletion
  • Prevent user from following themselves, not that it do much
  • Fix a translation string that was poorly translated (akumaaaaaa)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.242% when pulling 522cd0f on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.242% when pulling 522cd0f on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.242% when pulling 522cd0f on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.242% when pulling f28ba2f on fix into 530fd05 on dev.

@Kiloutre
Copy link
Contributor Author

Kiloutre commented Oct 28, 2017

@akuma06
How do i make it so that more recent notifications are shown first, just like torrents?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.242% when pulling 0174f8f on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.242% when pulling 0174f8f on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.242% when pulling 70effc6 on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.242% when pulling 70effc6 on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 38.881% when pulling 9f05945 on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 38.881% when pulling 6d33385 on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 38.881% when pulling e14983f on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 38.881% when pulling e14983f on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 38.881% when pulling af63263 on fix into 530fd05 on dev.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 38.881% when pulling af63263 on fix into 530fd05 on dev.

@Kiloutre Kiloutre merged commit 6f47f1b into dev Nov 2, 2017
@Kiloutre Kiloutre deleted the fix branch November 2, 2017 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants