Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the report save path to be always the same one & drop env for it #13

Merged
merged 2 commits into from
May 13, 2019

Conversation

NyanKiyoshi
Copy link
Owner

@NyanKiyoshi NyanKiyoshi commented May 13, 2019

Closes #10.

  • In Generate sums of queries #12, stopped storing the benchmark results in a file named after the current date and time.
    Instead, it will always save into .django-queries and won't contain a json file extension
    anymore to make it less appealing as it's not meant to be read by a human.
  • In Generate sums of queries #12, dropped the environment variable PYTEST_QUERIES_SAVE_PATH and replaced
    and introduced the --django-db-bench PATH option instead, which does exactly the same thing.

Changes Checklist

  • The changes were tested (manually)
  • The changes are tested automatically (pytest)
  • The changes are optimized and clean
  • The changes are documented:
    • The code is documented
    • The readme is up to date
    • The documentation (readthedocs) is up to date and tested

@NyanKiyoshi NyanKiyoshi added this to the v1.0.0b1 milestone May 13, 2019
@NyanKiyoshi NyanKiyoshi mentioned this pull request May 13, 2019
21 tasks
@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         130    128    -2     
  Branches       13     13           
=====================================
- Hits          130    128    -2
Impacted Files Coverage Δ
pytest_django_queries/plugin.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be405c...66132ac. Read the comment docs.

@NyanKiyoshi NyanKiyoshi merged commit fb37113 into master May 13, 2019
@NyanKiyoshi NyanKiyoshi deleted the feature/reports-stored-in-same-file branch May 13, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to customize the output file
2 participants