Default values for RabbitMq connection string (#86)

Nybus-project · Mar 6, 2019 · c58137e · c58137e
1 parent b7006b2
commit c58137e
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 4 deletions.
diff --git a/src/engines/Nybus.Engine.RabbitMq/Configuration/IConnectionFactoryProvider.cs b/src/engines/Nybus.Engine.RabbitMq/Configuration/IConnectionFactoryProvider.cs
@@ -35,10 +35,10 @@ public IConnectionFactory CreateFactory(IConfigurationSection settings)
 
             return new ConnectionFactory
             {
-                HostName = GetValueOrNull(connectionStringBuilder, "Hostname"),
-                UserName = GetValueOrNull(connectionStringBuilder, "Username"),
-                Password = GetValueOrNull(connectionStringBuilder, "Password"),
-                VirtualHost = GetValueOrNull(connectionStringBuilder, "VirtualHost"),
+                HostName = GetValueOrNull(connectionStringBuilder, "Hostname") ?? "localhost",
+                UserName = GetValueOrNull(connectionStringBuilder, "Username") ?? "guest",
+                Password = GetValueOrNull(connectionStringBuilder, "Password") ?? "guest",
+                VirtualHost = GetValueOrNull(connectionStringBuilder, "VirtualHost") ?? "/",
             };
         }
 

diff --git a/...sts.Nybus.Engine.RabbitMq/Configuration/ConnectionStringConnectionFactoryProviderTests.cs b/...sts.Nybus.Engine.RabbitMq/Configuration/ConnectionStringConnectionFactoryProviderTests.cs
@@ -49,6 +49,19 @@ public void CreateFactory_uses_given_hostName(ConnectionStringConnectionFactoryP
             Assert.That(factory.HostName, Is.EqualTo(value));
         }
 
+        [Test, CustomAutoMoqData]
+        public void CreateFactory_uses_default_hostName(ConnectionStringConnectionFactoryProvider sut, IConfigurationSection section)
+        {
+            var connectionStringBuilder = new DbConnectionStringBuilder();
+
+            Mock.Get(section).SetupGet(p => p.Value).Returns(connectionStringBuilder.ConnectionString);
+
+            var factory = sut.CreateFactory(section) as ConnectionFactory;
+
+            Assert.That(factory, Is.Not.Null);
+            Assert.That(factory.HostName, Is.EqualTo("localhost"));
+        }
+
         [Test, CustomAutoMoqData]
         public void CreateFactory_uses_given_username(ConnectionStringConnectionFactoryProvider sut, IConfigurationSection section, string value)
         {
@@ -63,6 +76,19 @@ public void CreateFactory_uses_given_username(ConnectionStringConnectionFactoryP
             Assert.That(factory.UserName, Is.EqualTo(value));
         }
 
+        [Test, CustomAutoMoqData]
+        public void CreateFactory_uses_default_username(ConnectionStringConnectionFactoryProvider sut, IConfigurationSection section)
+        {
+            var connectionStringBuilder = new DbConnectionStringBuilder();
+
+            Mock.Get(section).SetupGet(p => p.Value).Returns(connectionStringBuilder.ConnectionString);
+
+            var factory = sut.CreateFactory(section) as ConnectionFactory;
+
+            Assert.That(factory, Is.Not.Null);
+            Assert.That(factory.UserName, Is.EqualTo("guest"));
+        }
+
         [Test, CustomAutoMoqData]
         public void CreateFactory_uses_given_password(ConnectionStringConnectionFactoryProvider sut, IConfigurationSection section, string value)
         {
@@ -77,6 +103,19 @@ public void CreateFactory_uses_given_password(ConnectionStringConnectionFactoryP
             Assert.That(factory.Password, Is.EqualTo(value));
         }
 
+        [Test, CustomAutoMoqData]
+        public void CreateFactory_uses_default_password(ConnectionStringConnectionFactoryProvider sut, IConfigurationSection section)
+        {
+            var connectionStringBuilder = new DbConnectionStringBuilder();
+
+            Mock.Get(section).SetupGet(p => p.Value).Returns(connectionStringBuilder.ConnectionString);
+
+            var factory = sut.CreateFactory(section) as ConnectionFactory;
+
+            Assert.That(factory, Is.Not.Null);
+            Assert.That(factory.Password, Is.EqualTo("guest"));
+        }
+
         [Test, CustomAutoMoqData]
         public void CreateFactory_uses_given_virtualHost(ConnectionStringConnectionFactoryProvider sut, IConfigurationSection section, string value)
         {
@@ -90,5 +129,18 @@ public void CreateFactory_uses_given_virtualHost(ConnectionStringConnectionFacto
             Assert.That(factory, Is.Not.Null);
             Assert.That(factory.VirtualHost, Is.EqualTo(value));
         }
+
+        [Test, CustomAutoMoqData]
+        public void CreateFactory_uses_default_virtualHost(ConnectionStringConnectionFactoryProvider sut, IConfigurationSection section)
+        {
+            var connectionStringBuilder = new DbConnectionStringBuilder();
+
+            Mock.Get(section).SetupGet(p => p.Value).Returns(connectionStringBuilder.ConnectionString);
+
+            var factory = sut.CreateFactory(section) as ConnectionFactory;
+
+            Assert.That(factory, Is.Not.Null);
+            Assert.That(factory.VirtualHost, Is.EqualTo("/"));
+        }
     }
 }