temp fix (#126)

NybyDK · Apr 5, 2024 · c15ad13 · c15ad13
2 parents 1e7f262 + e7b8a3e
commit c15ad13
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/src/lib/classes/MPLS/CE.ts b/src/lib/classes/MPLS/CE.ts
@@ -16,7 +16,7 @@ export default class CE extends Router {
 
   updateAddress = (oldAddress: string, newAddress: string) => {
     const oldValue = this.firstHop.get(oldAddress);
-    if (!oldValue) {
+    if (oldValue === undefined) {
       alert(`Unable to update old first hop Address '${oldAddress}' to '${newAddress}'.`);
       return;
     }

diff --git a/src/lib/classes/MPLS/FIB.ts b/src/lib/classes/MPLS/FIB.ts
@@ -16,7 +16,7 @@ export default class FIB {
 
   updateAddress = (oldAddress: string, newAddress: string) => {
     const oldValue = this.map.get(oldAddress);
-    if (!oldValue) {
+    if (oldValue === undefined) {
       alert(`Unable to update old FIB address '${oldAddress}' to '${newAddress}'.`);
       return;
     }

diff --git a/src/lib/components/RouterSettings.svelte b/src/lib/components/RouterSettings.svelte
@@ -31,6 +31,12 @@
 <Dialog
   bind:dialog
   on:close={() => {
+    // TODO: Temporary fix to not crash app (ISSUE #125) - remove when fixed - it's because LSPList.svelte using getSureCERouter
+    if (router instanceof CE) {
+      for (const key of router.firstHop.keys()) {
+        if (key === "") router.firstHop.delete(key);
+      }
+    }
     network.notify();
   }}
 >

diff --git a/src/lib/components/RouterTables/Destination.svelte b/src/lib/components/RouterTables/Destination.svelte
@@ -19,8 +19,6 @@
 
     const target = event.target.value.toUpperCase();
 
-    router.updateAddress(destination, target);
-
     const destinationRouter = network.getCERouter(target);
 
     if (!destinationRouter) {
@@ -30,6 +28,9 @@
 
     const path = paths.findShortestPath(router, destinationRouter);
 
+    // Sounds counter-intuitive, but LDP sets an entry, and it cannot exist before because it returns if it already exists
+    router.deleteEntry(destination);
+
     LDP(path, target);
 
     router = router;