Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General upgrade #2

Merged
merged 30 commits into from
Mar 11, 2020
Merged

General upgrade #2

merged 30 commits into from
Mar 11, 2020

Conversation

corollari
Copy link
Contributor

@corollari corollari commented Jan 29, 2020

Improvements

  • Fixed the dependencies in order to get it to compile. Furthermore I've removed the dependency on neo-utils (a huge package).
  • Made some modifications to make it deployable on Heroku & wrote instructions on how to do it (this enables auto-scaling deployments!)
  • Updated the node lists
  • Fixed a bug that would cause the system to crash
  • Made the system crash when the connection to the node is lost (before it would continue chugging along as if it was working fine but it wouldn't send any updates to the websocket subscriptors nor would it reconnect, essentially it entered a no-recovery dead state while seeming healthy from the outside)
  • Added support for websocket relaying

I've also changed the main functional dependency on which this package is based (see O3Labs/neo-transaction-watcher#1) in order to make it work with the current p2p protocol used in neo nodes.

@apisit
Copy link
Contributor

apisit commented Feb 20, 2020

awesome to see this lib being used. it's been a long time. let me know when you want you are ready so we can merge it to master.

@corollari
Copy link
Contributor Author

I believe it is mergeable in it's current state, the only thing that would need to be changed are the github references (currently pointing at my personal repos).

Would you be interested in continuing the development of it? I've been recently thinking of which would be the best place to host it and was leaning towards just putting it under the CoZ umbrella (for extra visibility) but if you'd like to keep working on it or if people are already linking to this repository I'd be glad to just maintain it here.

@apisit apisit merged commit 1dcad12 into O3Labs:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants