Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal/Clarify Nullable - Add interactions with default #2058

Merged
merged 17 commits into from Nov 21, 2019

Conversation

@tedepstein
Copy link
Contributor

tedepstein commented Nov 17, 2019

Incorporating issue #2057, clarifying interactions between nullable and default keywords.

tedepstein added 10 commits Apr 17, 2018
Updating master from upstream repo
Catching up with changes in the upstream repo.
…adds a formal proposal to clarify the semantics of nullable, providing the necessary background and links to related resources.
@handrews

This comment has been minimized.

Copy link
Contributor

handrews commented on proposals/003_Clarify-Nullable.md in c58f5bf Oct 31, 2019

Super-nitpicky: I'd use double-quotes, "null", since officially JSON Schema is only defined to be written in JSON, and we want to make sure people realize that is the JSON string "null" and not the JSON literal null.

This writeup is great, btw, thanks for doing it!

tedepstein added 7 commits Oct 31, 2019
Thanks, @handrews for the review.
Somehow in our collaborative editing, we neglected to state that `nullable` adds `"null"` to the set of allowed types. We just said that it "expands" the `type` value, but didn't state the obvious (to us) manner of said expansion. Correcting that oversight in this commit.
…ing nulls by default.
@tedepstein

This comment has been minimized.

Copy link
Contributor Author

tedepstein commented Nov 17, 2019

@darrelmiller , @webron or someone else from TSC, please merge. This is an update to the nullable clarification proposal.

@darrelmiller darrelmiller merged commit b98e8c9 into OAI:master Nov 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.