Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use api-key instead of api_key as example header name #3226

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

perrinjerome
Copy link

Several HTTP servers drop http headers with underscores.

Fixes #3225

Several HTTP servers drop http headers with underscores.

Fixes OAI#3225
@@ -563,7 +563,7 @@ my.org.User
"securitySchemes": {
"api_key": {
"type": "apiKey",
"name": "api_key",
"name": "api-key",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I have only changed the name and kept the id to be "api_key", therefore later in "Security Requirement Object" section, it stays using "api_key"

###### Non-OAuth2 Security Requirement
```json
{
"api_key": []
}
```
```yaml
api_key: []
```

I first replaced all api_key by api-key but I thought it would be better to keep consistent api_key to have consistent naming with petstore_auth

@perrinjerome perrinjerome marked this pull request as ready for review April 1, 2023 13:26
Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrelmiller darrelmiller merged commit 6f7b9a4 into OAI:v3.1.1-dev Apr 13, 2023
charjr pushed a commit to charjr/OpenAPI-Specification that referenced this pull request Apr 27, 2023
Several HTTP servers drop http headers with underscores.

Fixes OAI#3225
charjr pushed a commit to charjr/OpenAPI-Specification that referenced this pull request Apr 27, 2023
Several HTTP servers drop http headers with underscores.

Fixes OAI#3225
@handrews handrews added this to the v3.1.1 milestone May 17, 2024
@handrews handrews added clarification requests to clarify, but not change, part of the spec http Supporting HTTP features and interactions examples requests for more or better examples in the specification security labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification requests to clarify, but not change, part of the spec examples requests for more or better examples in the specification http Supporting HTTP features and interactions security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants