Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings for header and cookie serialization (3.0.4) #3841

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Warnings for header and cookie serialization (3.0.4) #3841

merged 2 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. Warnings for header and cookie serialization (3.0.4) 

    This makes serializing cookie paramters and most header parameters
with `schema` and `style` NOT RECOMMENDED.
It is not clear that any `schema`-based serialization for cookies
will produce a correct value (although the reason is sufficiently
obscure that many implementations might ignore it and produce
cookie-compliant output anyway).
With headers, there are numerous pitfalls and only the simplest
scenarios will work properly, although perhaps the warning
here could be reworded to emphasize the safe scenarios more clearly.

The details are relegated to an appendix, because truly, most
people will not want to know.  But recommending against syntactically
legal configurations really does need to be explained in the spec.

Also, don't use

- in: header
  name: Cookie

Because... yeah.
    @handrews
    handrews committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    cd74c9d View commit details
    Browse the repository at this point in the history

  2. Fix spelling (review feedback) 

    Co-authored-by: Ralf Handl <ralf.handl@sap.com>
    @handrews @ralfhandl
    handrews and ralfhandl committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    96805ff View commit details
    Browse the repository at this point in the history