Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed story parser to use single lines instead of matching multiple #332

Merged
merged 2 commits into from
Apr 8, 2022
Merged

changed story parser to use single lines instead of matching multiple #332

merged 2 commits into from
Apr 8, 2022

Conversation

edewit
Copy link
Member

@edewit edewit commented Apr 7, 2022 •
edited
Loading

fixes: #301

@vorburger vorburger mentioned this pull request Apr 8, 2022
Closed
@vorburger vorburger mentioned this pull request Apr 8, 2022
Closed
vorburger
vorburger approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a next step. We should probably fix #333 next though.

@vorburger vorburger merged commit 73e421e into OASIS-learn-study:develop Apr 8, 2022
vorburger added a commit to vorburger/minecraft-storeys-maker that referenced this pull request Apr 8, 2022
@vorburger
Add missing test coverage
3d0789b 
While OASIS-learn-study#332 fixed OASIS-learn-study#301, it didn't actually
add any non-regression test coverage for that;
this adds that (using the reproducer from the bug).
@vorburger vorburger mentioned this pull request Apr 8, 2022
Merged
vorburger added a commit to vorburger/minecraft-storeys-maker that referenced this pull request Apr 8, 2022
@vorburger
Add moar test coverage (fixes OASIS-learn-study#281)
b034d75 
The OASIS-learn-study#332 for OASIS-learn-study#301 actually fixed OASIS-learn-study#281 as well;
this just adds non-regression test coverage for that.
@vorburger vorburger mentioned this pull request Apr 8, 2022
Merged
edewit pushed a commit that referenced this pull request Apr 8, 2022
@vorburger
Add missing test coverage (#335)
bb3bd75 
While #332 fixed #301, it didn't actually
add any non-regression test coverage for that;
this adds that (using the reproducer from the bug).
edewit pushed a commit that referenced this pull request Apr 8, 2022
@vorburger
Add moar test coverage (fixes #281) (#337)
26f0143 
The #332 for #301 actually fixed #281 as well;
this just adds non-regression test coverage for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vorburger vorburger vorburger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

story parser is buggy, inline JS is not properly parsed
2 participants
@edewit @vorburger