[WIP] Compatibility with Swift 3.0 (up to Xcode 8 GM) #267

nighthawk · 2016-08-17T06:17:29Z

This includes both changes suggested by Xcode's migration tool as well as manual fixing of the issues that Xcode couldn't migrate.

Action list:

cambuilt · 2016-08-25T17:34:08Z

I needed to make additional manual migration changes for Xcode 8, beta 6, but when trying to authenticate to Yelp, I get INVALID_SIGNATURE consistently and despite numerous code reviews. Using the Swift 2.0 version of OAuthSwift with Xcode 7.3 however, it works fine.

Any ideas?

nighthawk · 2016-08-27T01:55:16Z

@dongri, @rvangraan, can either of you double check Int+OAuthSwift.swift. The migrator failed on that file and I'm not sure if I manual migration is correct.

nighthawk · 2016-08-27T01:57:56Z

I'm still stuck on getting the tests to work again as Erik and its dependencies haven't yet been upgraded to Swift 3. @phimage, any advice on that?

cambuilt · 2016-08-27T14:50:39Z

I have given up on OAuthSwift for Swift 3 and using simple URLRequest and URLSession with dataTasks to authenticate to Yelp. I was only using maybe 1% of the capability of OAuthSwift and was getting tired of fixing the code for every new beta of Xcode 8.

Sent from my iPad Pro

On Aug 26, 2016, at 9:57 PM, Adrian Schoenig notifications@github.com wrote:

I'm still stuck on getting the tests to work again as Erik and its dependencies haven't yet been upgraded to Swift 3. @phimage, any advice on that?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

phimage · 2016-08-27T17:09:41Z

@cambuilt swift3 is in beta, xcode is in beta, what do you expect...
When coding in Swift 3 beta, get accustomed to updating your previous code
You can make a local repo or remote one with your own updates... (a pod update will not erase your change)

@nighthawk I make a swift3.0 branch today. There is some bug in unit test but all compile
Thanks for all your work

nighthawk · 2016-08-28T00:21:54Z

Tests are compiling again and all but OAuth2SwiftTests.testExpire() are succeeding.

Small adjustment to OAuthSwiftHTTPRequest.start() to pass on HTTP response error code rather than using default value of -1

nighthawk · 2016-08-28T00:46:39Z

OAuthSwift/OAuthSwiftHTTPRequest.swift

@@ -160,17 +163,16 @@ open class OAuthSwiftHTTPRequest: NSObject, URLSessionDelegate, OAuthSwiftReques
                            }
                        }
                    } else {
-                        localizedDescription = OAuthSwiftHTTPRequest.descriptionForHTTPStatus(self.response.statusCode, responseString: String(data: self.responseData as Data, encoding: self.dataEncoding)!)
+                        errorCode = httpResponse.statusCode


This line fixes testExpire as otherwise -1 would be returned.

(Don't get confused by GitHub showing that localizedDescription got removed, it just moved down one line.)

Yes that was fixed in master branch

nighthawk · 2016-08-28T00:47:01Z

All tests are succeeding now.

cambuilt · 2016-08-28T22:29:02Z

I thought a fork would at least build, but let me know if that should not be expected, since I am relatively new to Github.

On Aug 27, 2016, at 1:09 PM, Eric Marchand notifications@github.com wrote:

@cambuilt https://github.com/cambuilt swift3 is in beta, xcode is in beta, what do you expect...

When coding in Swift 3 beta, get accustomed to updating your previous code
You can make a local repo or remote one with your own updates... (a pod update will not erase your change)

@nighthawk https://github.com/nighthawk I make a swift3.0 branch today. There is some bug in unit test but all compile
Thanks for all your work

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #267 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ALClF3zS67XavXLY1NehB3UeXloF1KQ5ks5qkG9XgaJpZM4JmIPd.

nighthawk · 2016-08-28T22:40:02Z

@cambuilt, this pull request is marked as WIP, which stands for Work in Progress.

For you issue, it would be much appreciated if you can provide a test case to SignTests.swift with the inputs and the expected signature.

cambuilt · 2016-08-28T22:42:41Z

Not sure how I can do that without giving you my client id and secret, in this case.

On Aug 28, 2016, at 6:40 PM, Adrian Schoenig notifications@github.com wrote:

@cambuilt https://github.com/cambuilt, this pull request is marked as WIP, which stands for Work in Progress.

For you issue, it would be much appreciated if you can provide a test case to SignTests.swift with the inputs and the expected signature.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #267 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ALClF25uh_eIMuqpLao7FGuGMKwfTBxQks5qkg5FgaJpZM4JmIPd.

nighthawk · 2016-08-28T22:58:50Z

You could replace those with random strings and see if the different versions of OAuthSwift still come up with different signatures.

From what I've noticed in the past (#165 and #168), the issues were with other parts of the input than the client ID and secret.

cambuilt · 2016-08-28T23:03:28Z

Wouldn't the oauth_timestamp have to be identical for both to get a valid result?

On Aug 28, 2016, at 6:58 PM, Adrian Schoenig notifications@github.com wrote:

You could replace those with random strings and see if the different versions of OAuthSwift still come up with different signatures.

From what I've noticed in the past (#165 #165 and #168 #168), the issues were with other parts of the input than the client ID and secret.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #267 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ALClFzrUI9s2TYbLIAZ8pPZ0P4F4E1Maks5qkhKsgaJpZM4JmIPd.

nighthawk · 2016-08-28T23:10:48Z

A fixed timestamp is fine for the tests - check out the other tests for comparison.

cambuilt · 2016-08-28T23:12:28Z

Thanks.

On Aug 28, 2016, at 7:10 PM, Adrian Schoenig notifications@github.com wrote:

A fixed timestamp is fine for the tests - check out the other tests for comparison.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #267 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ALClF0iHQJwzE5jJqL-aEO6j9eUnCszBks5qkhV6gaJpZM4JmIPd.

phimage · 2016-09-11T07:22:06Z

I think some function renaming is needed to follow the new guidelines by omitting needless words.
but can be done after merging into master if conflict appear when doing it
examples:

authorizeWithCallbackURL(_ callbackURL: URL.. -> authorize(callbackURL: URL
postOAuthAccessTokenWithRequestTokenByCode(_ code: String.. ->
renewAccessTokenWithRefreshToken(_ refreshToken: String ->

s-aska · 2016-09-13T05:11:57Z

ci you apply this fix has been successful.
https://travis-ci.org/s-aska/TwitterAPI/builds/159495700

github "skedgo/OAuthSwift" "63bdf693004537f23436c8330cd9410e5ad88a54"

Very Thanks.

This fixes When you are merge.

But probably OAuthSwiftTVOS and OAuthSwiftWatchOS requires a convert.

OAuthSwiftTVOS

“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
warning: no umbrella header found for target 'OAuthSwiftTVOS', module map will not be generated

OAuthSwiftWatchOS

“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
warning: no umbrella header found for target 'OAuthSwiftWatchOS', module map will not be generated

phimage · 2016-09-13T06:26:50Z

Not a real convert, just open the targets > build settings look for “Use Legacy Swift Language Version”. Changer "Unspecified" to "No"

phimage · 2016-09-15T10:13:57Z

create swift-version file with 3.0 inside see Create a swift-version file #274

old comment

open the targets > build settings look for “Use Legacy Swift Language Version”. Changer "Unspecified" to "No"
rename some functions

max-potapov · 2016-09-22T09:40:29Z

@phimage OAuthSwift:swift3.0 is 17 (!) commits behind the OAuthSwift:master and missing some parts of latest release like OAuthWebViewControllerDelegate for example.

May I ask you to rebaseswift3.0 branch and this PR to master branch? It will allow to use OAuthSwift with applications which was already converted to Swift 3.0 syntax.

phimage · 2016-09-22T10:17:10Z

If @nighthawk can squash its commits until 3 days I will merge into master branch ( and do some change function naming, etc...).
If not I will open master branch codes into xcode 8 and do the conversion job (but I want to keep @nighthawk work if possible, but not 19 commits)

nighthawk · 2016-09-23T05:15:29Z

@phimage, I've squashed the commits and opened a new PR: #277. It's still based on the previous swift 3.0 branch as I'm not entirely comfortable with merging in the changes that have since been made to master (due to the merge conflicts).

Adrian Schoenig added 12 commits June 24, 2016 11:28

Update OAuthSwift.podspec

453fbc8

Update OAuthSwift.podspec

a238d75

Update OAuthSwift.podspec

5421efb

Custom name of pod

2679a12

Merge commit '2679a' into swift3.0

6baaa42

Swift 3 beta 5 fixes

17f3f30

Use same name as main repo

72219e4

Swift 3 beta 5 fix

41eb189

Xcode’s migration for beta 6

3e65c41

Xcode 8 beta 6 fixes

d3ddc83

Migrating tests

6c12660

Restore original name

b25e4b1

phimage mentioned this pull request Aug 19, 2016

When will there be swift 3 support? #244

Closed

SSheldon mentioned this pull request Aug 26, 2016

INVALID_SIGNATURE with Swift 3 Xcode 8 beta 6 Yelp/yelp-ios#41

Closed

Adrian Schoenig added 5 commits August 28, 2016 10:04

oAuth => OAuth

5fb44dc

Test compile fixes

6ff3bd1

Podfile comments

88cf829

Fixing test failure

dc3fe48

Improve readability

bfa80d8

Fixing OAuth2SwiftTests.testExpire

35f6f0d

Small adjustment to OAuthSwiftHTTPRequest.start() to pass on HTTP response error code rather than using default value of -1

nighthawk reviewed Aug 28, 2016
View reviewed changes

Xcode 8 GM fixes

63bdf69

nighthawk changed the title ~~[WIP] Compatibility with Swift 3.0 (up to Xcode 8 beta 6)~~ [WIP] Compatibility with Swift 3.0 (up to Xcode 8 GM) Sep 8, 2016

phimage mentioned this pull request Sep 15, 2016

Create a swift-version file #274

Merged

nighthawk mentioned this pull request Sep 23, 2016

Swift 3 and Xcode 8 fixes #277

Merged

5 tasks

nighthawk closed this Sep 23, 2016

nighthawk deleted the swift3.0 branch September 23, 2016 05:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Compatibility with Swift 3.0 (up to Xcode 8 GM) #267

[WIP] Compatibility with Swift 3.0 (up to Xcode 8 GM) #267

nighthawk commented Aug 17, 2016 •

edited by phimage

cambuilt commented Aug 25, 2016

nighthawk commented Aug 27, 2016

nighthawk commented Aug 27, 2016

cambuilt commented Aug 27, 2016

phimage commented Aug 27, 2016

nighthawk commented Aug 28, 2016

nighthawk Aug 28, 2016 •

edited

phimage Aug 28, 2016

nighthawk commented Aug 28, 2016

cambuilt commented Aug 28, 2016

nighthawk commented Aug 28, 2016 •

edited

cambuilt commented Aug 28, 2016

nighthawk commented Aug 28, 2016

cambuilt commented Aug 28, 2016

nighthawk commented Aug 28, 2016

cambuilt commented Aug 28, 2016

phimage commented Sep 11, 2016

s-aska commented Sep 13, 2016 •

edited

phimage commented Sep 13, 2016

phimage commented Sep 15, 2016

max-potapov commented Sep 22, 2016

phimage commented Sep 22, 2016

nighthawk commented Sep 23, 2016 •

edited

[WIP] Compatibility with Swift 3.0 (up to Xcode 8 GM) #267

[WIP] Compatibility with Swift 3.0 (up to Xcode 8 GM) #267

Conversation

nighthawk commented Aug 17, 2016 • edited by phimage

cambuilt commented Aug 25, 2016

nighthawk commented Aug 27, 2016

nighthawk commented Aug 27, 2016

cambuilt commented Aug 27, 2016

phimage commented Aug 27, 2016

nighthawk commented Aug 28, 2016

nighthawk Aug 28, 2016 • edited

Choose a reason for hiding this comment

phimage Aug 28, 2016

Choose a reason for hiding this comment

nighthawk commented Aug 28, 2016

cambuilt commented Aug 28, 2016

nighthawk commented Aug 28, 2016 • edited

cambuilt commented Aug 28, 2016

nighthawk commented Aug 28, 2016

cambuilt commented Aug 28, 2016

nighthawk commented Aug 28, 2016

cambuilt commented Aug 28, 2016

phimage commented Sep 11, 2016

s-aska commented Sep 13, 2016 • edited

OAuthSwiftTVOS

OAuthSwiftWatchOS

phimage commented Sep 13, 2016

phimage commented Sep 15, 2016

max-potapov commented Sep 22, 2016

phimage commented Sep 22, 2016

nighthawk commented Sep 23, 2016 • edited

nighthawk commented Aug 17, 2016 •

edited by phimage

nighthawk Aug 28, 2016 •

edited

nighthawk commented Aug 28, 2016 •

edited

s-aska commented Sep 13, 2016 •

edited

nighthawk commented Sep 23, 2016 •

edited