fix urlEncodedStringWithEncoding to remove reserved characters

[tkawaji]

There is signiture error when parameter value includes line feed code(\n).
So I basically use NSCharacterSet.URLQueryAllowedCharacterSet for stringByAddingPercentEncodingWithAllowedCharacters.
And remove some characters defined as reserved in RFC 3986.

I think there are big changes in urlencoding behavior from existing source code.
So I would appreciate if you could check carefully.

Thank you.

[phimage]

yes it's a thing to look carefully

there is some code here also #115

And after studying the case of space character here #156, I read in RFC that there is two things
Encoding for signature and for further url request

Did you try to launch unit test using the workspace and pod command to retrieve dependencies?
there is a signatureTest for only one case

[tkawaji]

I couldn't setup unit test environment.
Is there any document about how to launch unit test?

[phimage]

No sorry, I must do it one day

Cocoapod must be installed

sudo gem install cocoapods

(close any xcode OAuthSwift project if opened)
in OAuthSwift directory

 pod install

open OAuthSwift.xcworkspace (not OAuthSwift.xcodeproj)

To launch test, choose scheme OAuthSwiftTests and do Menu:Product then Test (Command U)

[phimage]

Just tested testSignature and it's ok

[tkawaji]

Thank you.

I setup test environment, but I have some error:
"HttpResponseBody has no member STRING"

I think that version of Swifter is different.
need Podfile.lock?

[phimage]

Swifter was 1.0.2 instead of 1.0.6 in my repository
I fix that, thanks : b819075

[tkawaji]

Thank you. I could run test case.
And testSignature is OK, too.

[phimage]

PR #201 merged