Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters in OAuth1 callback #152

Merged
merged 2 commits into from Nov 30, 2015
Merged

Conversation

quangbuule
Copy link
Contributor

This solves #81.
For instance: Twitter auth callback contains user_id that can't be found in any other APIs.

@phimage
Copy link
Member

phimage commented Nov 29, 2015

Thank you
I can develop from now but by just watching, I think demo code must be updated too by adding parameters into callback before "in"
https://github.com/dongri/OAuthSwift/blob/master/OAuthSwiftDemo/ViewController.swift

And If you can readme.md too by adding parameters also to oauth1 example

in your next commit message add : fix #81 for auto close (maybe this work also with PR title)

@quangbuule
Copy link
Contributor Author

Hi @phimage, I just updated the pull request. Please review again, thank you.

@phimage
Copy link
Member

phimage commented Nov 30, 2015

missing also in test, I do it

phimage added a commit that referenced this pull request Nov 30, 2015
Add parameters in OAuth1 callback
@phimage phimage merged commit dfcd9b7 into OAuthSwift:master Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants