Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parsing of id_token, if present in access token response #679

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

colinhumber
Copy link
Contributor

Adds support for parsing of id_token, if present, when fetching an access token. Details on why this is useful is in #668, specifically to support Single Sign Out with a redirect URI.

@phimage
Copy link
Member

phimage commented Oct 8, 2021

Hi,

Ok we just decode it if present and store it in memory into OAuthSwiftCredential

No need to store it ? in keychain for instance with other credential object informations

There is support of Codable and old NSCoder too

ps: I could merge anyway but could wait

@colinhumber
Copy link
Contributor Author

I missed encoding/decoding with Codable and NSCoder support on OAuthSwiftCredential. I'll add that in.

@MikeSpelling
Copy link

Is this still being looked at? I also need the id_token for single sign-out so would appreciate the merge!

@MikeSpelling
Copy link

Any reason this is still unmerged?

@ramden
Copy link

ramden commented Dec 11, 2023

Same question, why still unmerged? This would be very usable, because the library seems to lack proper logout and id_token is needed to acheive that via manually requests

@phimage phimage merged commit 2dcf238 into OAuthSwift:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants