Update SOP.md to add guidance on community contributions to review #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlharris
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
This looks good. The only comment I have is regarding
the NOR manager assigns the next available OBO operation member to act as designated NOR Reviewer.
What do you think about adding something about how to determine the "next available OBO operation member"?
Actually, I have one other comment: would it be helpful to add links to info about the automated (Dashboard) review?
Co-authored-by: Nomi Harris <nlharris@users.noreply.github.com>
|
Thanks for the suggestions Nomi! Text on how to determine the "next available OBO operation member" is already provided within the NOR Manager role document, which is cited. I think links to info about the automated (Dashboard) review are in that doc too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2459.