Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate travis as a way to vet PRs #2

Closed
cmungall opened this issue Oct 27, 2015 · 4 comments
Closed

Evaluate travis as a way to vet PRs #2

cmungall opened this issue Oct 27, 2015 · 4 comments

Comments

@cmungall
Copy link
Contributor

Assuming we could write some kind of validator for the htaccess files, it should be easy to write a .travis.yml that can be used to assist with PR evaluation.

@jamesaoverton
Copy link
Member

Minimally, Travis could install a minimal Apache2 and run apachectl configtest: https://httpd.apache.org/docs/2.4/programs/apachectl.html

This was referenced Nov 5, 2015
@jamesaoverton
Copy link
Member

The current code uses Ansible and targets Debian 8 (Jessie). This works well for Vagrant and deployment. But Travis uses shell commands and Ubuntu 12.04: http://docs.travis-ci.com/user/installing-dependencies/

Switching from Debian to Ubuntu is not a big deal.

This guy uses Ansible inside Travis, but that strikes me as a bad idea: https://servercheck.in/blog/testing-ansible-roles-travis-ci-github

@jamesaoverton
Copy link
Member

I want to pull from master directly to production, run make, and assume that everything will work. That could be contingent on a green light from Travis? Their API exposes last_build_status: http://docs.travis-ci.com/api/?http#repositories

If we can't do that, we'll have to do some sort of automatic rollback...

jamesaoverton added a commit that referenced this issue Nov 13, 2015
- switch Vagrant to ubuntu/trusty64 to match Travis Beta
- improve Vagrantfile and Ansible site.yml
- update .travis.yml with first pass instructions
- update README about Linux version
jamesaoverton added a commit that referenced this issue Nov 13, 2015
jamesaoverton added a commit that referenced this issue Nov 13, 2015
- only install Apache if initial build succeeds
jamesaoverton added a commit that referenced this issue Nov 13, 2015
- update Makefile to check Travis and update on new greeen master
- update site.yml to install `travis` and use `make safe-update`
- update .gitignore
@jamesaoverton
Copy link
Member

After a monstrous amount of trial and error, I think this is working correctly.

@jamesaoverton jamesaoverton added this to the Initial release milestone Nov 19, 2015
jamesaoverton pushed a commit that referenced this issue Jul 13, 2016
wdduncan added a commit that referenced this issue Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants