Change default OLS viewer to OLS4

[matentzn]

fixes #920

Blocked by

• Provide a single redirect for term browsers EBISPOT/ols4#378

[jamesaoverton]

The double percent signs are important, because this string is being run through Python string formatting, which also uses percent signs (%s). I guess we could switch to Python f-strings for better readability.

This line in the tests will also need to be updated:

purl.obolibrary.org/tools/test.py

Line 179 in d0f9167

ols = 'https://www.ebi.ac.uk/ols/ontologies/%s/terms?iri=http%%3A%%2F%%2Fpurl.obolibrary.org%%2Fobo%%2F'

[matentzn]

@lschriml @allysonlister and Robert Thacker have confirmed, @dosumis not (but I know he wants this).

@mcourtot I am also sure will agree, so I will take the blame for that. Remains the blocking OLS issue above!

[mcourtot]

Didn't realize this was pending confirmation - all good to me, thank you!

[matentzn]

Ok last problem, no idea whats that about:
https://github.com/OBOFoundry/purl.obolibrary.org/actions/runs/5424480866/jobs/9863896909?pr=922

Seems that the OLS PURL send back a HTTP 303. @serjoshua @udp - any idea why that is? If you click on the URLs they resolve, albeit a bit indirectly and slowly..

[jamesaoverton]

Don't worry about the fact that the code is "303". There was a decision many years ago to use "303 See Other" for term IRIs.

The problem is that the expected and actual URLs aren't matching up. Not sure why.

[matentzn]

@jamesaoverton I got the tests to pass. Note that I am a bit confused why I needed to double encode the entity IRI here to get it to work, but I think its because they moved from "URL parameter" syntax (?iri=) to "URL path" syntax.

[jamesaoverton]

Yes, moving from the query string into the path seems to require the extra escape. It's very ugly but it seems to work fine.

[serjoshua]

I was just reviewing some OLS4 tickets and stumbled upon this. We do support ?iri=, ?shortForm= and ?oboId= (?curie=) for /terms and /entities. What we do not support on the frontend is ?id=. If you encounter any discrepancies, let us know. Thanks.

[jamesaoverton]

I tested locally and convinced myself that the extra escapes are required.

I'll merge this tomorrow morning when we're both at our desks.