Update release versions redirects for CL #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the redirect for the prefix `/about/` to use OLS instead of Ontobee to be aligned with the term browser.
config/cl.yml
Outdated
| @@ -68,8 +68,35 @@ entries: | |||
| - prefix: /2011-12-13/ | |||
| replacement: https://cell-ontology.googlecode.com/svn/releases/2011-12-13/ | |||
|
|
|||
| - regex: ^/releases/(201.*)/ | |||
There was a problem hiding this comment.
We don't use the regex system very often. The examples in the README all end with $ but I don't think that's what you want here.
I think you could get what you want with a series of prefix rules.
There was a problem hiding this comment.
Also, it's conflicting with the new rule for release.
There was a problem hiding this comment.
This is still failing the tests.
Entries are processed in order from top to bottom, which is why I think that a series of prefix entries will do what you want.
There was a problem hiding this comment.
Will it work to only change the key regex to prefix?
|
Thank you, James! 🙏🏼 |
|
I think this is what you want. It passes all the tests you wrote. Good to merge? |
|
Yes, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates the redirect for the prefix
/about/to use OLS instead of Ontobee to be aligned with the term browser.Related to obophenotype/cell-ontology#2048