Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][10.0][MIG] account_asset_analytic #102

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

luismontalba
Copy link
Member

Account asset analytic

This module allows you to define an analytic account per asset and creates
expenses moves with that analytic account instead of the analytic account
per category, as the standard does.
It also propagates analytic account from invoice line to analytic account line.

cc @Tecnativa

@luismontalba luismontalba changed the title [10.0][MIG] account_asset_analytic [WIP][10.0][MIG] account_asset_analytic May 24, 2017
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little changes, but overall OK

@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
# © 2016 Antonio Espinosa - <antonio.espinosa@tecnativa.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove copyright from init files.

@@ -0,0 +1,22 @@
# -*- coding: utf-8 -*-
# © 2016 Antonio Espinosa - <antonio.espinosa@tecnativa.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace © by Copyright and add yours

"summary": "Adds analytic account per asset",
"version": "10.0.1.0.0",
"category": "Analytic Accounting",
"website": "http://www.tecnativa.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https

"application": False,
"installable": True,
"depends": [
"account_asset",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it depend on analytic?

Copy link
Member Author

@luismontalba luismontalba May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but throw this route:
account_asset > account_accountant > account > analytic

@@ -0,0 +1,8 @@
# -*- coding: utf-8 -*-
# © 2016 Antonio Espinosa - <antonio.espinosa@tecnativa.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove copyright here

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The drop in coverage means that there are certain things untested. See here what it's untested and check, because I think that the analytic account propagation to the asset is not correct:

https://codecov.io/gh/OCA/account-analytic/compare/8e5514369405d8bb2980c65add9b41a1666d0f43...4f61bdaf9d6969b32b0edda3380efadde02af1b6/diff

@luismontalba luismontalba changed the title [WIP][10.0][MIG] account_asset_analytic [10.0][MIG] account_asset_analytic May 25, 2017
@luismontalba luismontalba changed the title [10.0][MIG] account_asset_analytic [WIP][10.0][MIG] account_asset_analytic May 25, 2017
@luismontalba
Copy link
Member Author

Runbot can't build due to other modules test

@pedrobaeza
Copy link
Member

Runbot is building, but it fails with a warning. Anyway, it's possible to test the module in runbot.

@pedrobaeza
Copy link
Member

@cubells can you review?

Copy link
Sponsor Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Code review and tested

@pedrobaeza pedrobaeza force-pushed the 10.0-mig-account_asset_analytic branch from f4f3eed to 3bf212e Compare June 9, 2017 01:33
@pedrobaeza pedrobaeza merged commit 02d9950 into OCA:10.0 Jun 9, 2017
@pedrobaeza pedrobaeza deleted the 10.0-mig-account_asset_analytic branch June 9, 2017 01:33
@pedrobaeza pedrobaeza mentioned this pull request Jun 9, 2017
24 tasks
tschanzt pushed a commit to camptocamp/account-analytic that referenced this pull request Sep 26, 2018
Fix assignation on recordset with len > 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants