-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig analytic tag dimension purchase warning #149
11.0 mig analytic tag dimension purchase warning #149
Conversation
1fbd38f
to
d842a56
Compare
"version": "11.0.1.0.0", | ||
"license": "AGPL-3", | ||
"author": "Camptocamp SA,Odoo Community Association (OCA)", | ||
"website": "http://www.camptocamp.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"category": "Generic Modules/Accounting", | ||
"version": "11.0.1.0.0", | ||
"license": "AGPL-3", | ||
"author": "Camptocamp SA,Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "SA"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate authors w/ space please 😄
"category": "Generic Modules/Accounting", | ||
"version": "11.0.1.0.0", | ||
"license": "AGPL-3", | ||
"author": "Camptocamp SA,Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate authors w/ space please 😄
"website": "http://www.camptocamp.com", | ||
"depends": [ | ||
'analytic_tag_dimension', | ||
'purchase' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a trailing comma
d842a56
to
d29006f
Compare
d29006f
to
a79878b
Compare
NOTE: depends on #146 -> oca_dependencies.txt to be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oca_dependencies to update, otherwise LGTM ! 👍
oca_dependencies.txt
Outdated
@@ -0,0 +1,3 @@ | |||
# list the OCA project dependencies, one per line | |||
# add a github url if you need a forked version | |||
account-analytic https://github.com/arkostyuk/account-analytic 11.0-mig-analytic_tag_dimension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As #146 is merged, you can remove this line.
a79878b
to
6d07b57
Compare
No description provided.