Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig analytic tag dimension purchase warning #149

Merged

Conversation

mpanarin
Copy link

@mpanarin mpanarin commented Jan 5, 2018

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request Jan 5, 2018
28 tasks
@mpanarin mpanarin force-pushed the 11.0-mig-analytic_tag_dimension_purchase_warning branch from 1fbd38f to d842a56 Compare January 9, 2018 15:22
"version": "11.0.1.0.0",
"license": "AGPL-3",
"author": "Camptocamp SA,Odoo Community Association (OCA)",
"website": "http://www.camptocamp.com",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"category": "Generic Modules/Accounting",
"version": "11.0.1.0.0",
"license": "AGPL-3",
"author": "Camptocamp SA,Odoo Community Association (OCA)",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "SA"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate authors w/ space please 😄

"category": "Generic Modules/Accounting",
"version": "11.0.1.0.0",
"license": "AGPL-3",
"author": "Camptocamp SA,Odoo Community Association (OCA)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate authors w/ space please 😄

"website": "http://www.camptocamp.com",
"depends": [
'analytic_tag_dimension',
'purchase'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a trailing comma

@mpanarin mpanarin force-pushed the 11.0-mig-analytic_tag_dimension_purchase_warning branch from d842a56 to d29006f Compare January 18, 2018 13:44
@mpanarin mpanarin force-pushed the 11.0-mig-analytic_tag_dimension_purchase_warning branch from d29006f to a79878b Compare January 24, 2018 14:40
@simahawk
Copy link

NOTE: depends on #146 -> oca_dependencies.txt to be updated

Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oca_dependencies to update, otherwise LGTM ! 👍

@@ -0,0 +1,3 @@
# list the OCA project dependencies, one per line
# add a github url if you need a forked version
account-analytic https://github.com/arkostyuk/account-analytic 11.0-mig-analytic_tag_dimension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #146 is merged, you can remove this line.

@mpanarin mpanarin force-pushed the 11.0-mig-analytic_tag_dimension_purchase_warning branch from a79878b to 6d07b57 Compare January 31, 2018 09:12
@yvaucher yvaucher merged commit d19027f into OCA:11.0 Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants