Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [FIX] stock_analytic: Analytic account field is in wrong page #258

Merged
merged 1 commit into from Oct 17, 2019
Merged

[12.0] [FIX] stock_analytic: Analytic account field is in wrong page #258

merged 1 commit into from Oct 17, 2019

Conversation

Jerther
Copy link
Member

@Jerther Jerther commented Oct 16, 2019

Fixes #257

AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

MiquelRForgeFlow
MiquelRForgeFlow suggested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be two xpaths instead. One for the move_line_ids_without_package and the other for the move_ids_without_package.

@Jerther
Copy link
Member Author

Jerther commented Oct 17, 2019

@mreficent The problem is, the field is readonly in move_line_ids_without_package and pretty much useless (see related issue). Adding readonly=False to the field declaration works but the field becomes blank when saving so I'd have to dig deeper.

In fact, correct me if I'm wrong, but the fields used to have different names in 11.0 so could it be that the inherited view used the wrong field in the migration from 11.0 to 12.0? If so, this PR really is a fix to that problem and we could make a separate issue of adding the analytic account field to move_line_ids_without_package, which I'm actually willing to take care of eventually but not right now 😉

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-258-by-aheficent-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 17, 2019
@OCA-git-bot
Merge PR #258 into 12.0
077509d 
Signed-off-by aheficent
@OCA-git-bot OCA-git-bot merged commit 5993fc6 into OCA:12.0 Oct 17, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c4b6706. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[12.0] stock_analytic: analytic_account_id field is read only!
4 participants
@Jerther @AaronHForgeFlow @OCA-git-bot @MiquelRForgeFlow