-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] 8.0 migration of analytic_secondaxis #29
Conversation
""" | ||
Add a second analytical axis on analytic lines allowing you to make | ||
reporting on. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract this into README.rst file and use OCA's template (https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9ef20c2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to remove it from here then.
) | ||
display_name = fields.Char( | ||
string='Display Name ', | ||
compute=_compute_display_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put method name between quotes to make it easily inheritable.
[IMP] : unify using sample quote instead double quotes
You don't need to change all double quotas to single. They act the same. As you can see, default methods cannot be enclosed by quotes, because it can't be distinguished between an string value and a method. |
Thanks for you explanation, It's clear now, I'll take it in consideration. |
[IMP] : add check for recursivity on project activity
Cut lines > 79
Partner summary
No description provided.