Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] 8.0 migration of analytic_secondaxis #29

Closed
wants to merge 13 commits into from

Conversation

AdilHoumadi
Copy link

No description provided.

"""
Add a second analytical axis on analytic lines allowing you to make
reporting on.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract this into README.rst file and use OCA's template (https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 9ef20c2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to remove it from here then.

)
display_name = fields.Char(
string='Display Name ',
compute=_compute_display_name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put method name between quotes to make it easily inheritable.

@coveralls
Copy link

Coverage Status

Coverage decreased (-48.02%) to 51.98% when pulling 2053f09 on taktik:8.0-mig-analytic-secondaxis-ah into 4ef65fa on OCA:8.0.

@pedrobaeza
Copy link
Member

You don't need to change all double quotas to single. They act the same.

As you can see, default methods cannot be enclosed by quotes, because it can't be distinguished between an string value and a method.

@AdilHoumadi
Copy link
Author

Thanks for you explanation, It's clear now, I'll take it in consideration.
Thank you for this review !

[IMP] : add check for recursivity on project activity
tschanzt pushed a commit to camptocamp/account-analytic that referenced this pull request Sep 26, 2018
sbejaoui pushed a commit to acsone/account-analytic that referenced this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants