-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] Migrate budget & budget_crm #14
Conversation
depends on OCA/account-analytic#34 |
8fdc0c8
to
be7dc55
Compare
groups_id: | ||
- budget.group_budget_responsible | ||
- account.group_account_manager | ||
- account.group_account_manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no newline here
I added a few remarks @damdam-s. Thanks for your work! |
694de92
to
7ae08bf
Compare
@lepistone update for some comments |
@damdam-s @charbeljc Thanks. Some others are unanswered. If what I say is inconvenient or wrong or not worth it, you can answer "No" to them 😸 |
1074e19
to
69d7985
Compare
just rebased now and OCA/account-analytic#34 has been merged |
👍 |
@damdam-s if you can please add just a line in the yaml test saying that the user is admin because of the bug, I approve this. Thanks! |
@lepistone it's done here (see last commit): https://github.com/OCA/account-budgeting/pull/14/files#diff-f232e911695f7dace0426943f2c08124R3 |
you're right @damdam-s! I think it's because github shows comments in the context they were written. Then 👍 thanks! |
@lepistone thanks :) |
@vrenaville @mdietrichc2c ping |
@tafaRU @jbeficent @eLBati @max3903 @pedrobaeza @sbidoul as you are part of the Accounting PSC, can you have a look at this PR ? Many thanks |
👍 Thanks |
👍 Thanks for the migration |
No description provided.