Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] [ADD] account_budget_template #21

Merged
merged 5 commits into from
Jun 13, 2019

Conversation

dalonsod
Copy link

A budget template contains different budgetary positions and defines a periodicity
to create with a button the corresponding lines.

@oihane
Copy link
Contributor

oihane commented May 28, 2019

You also have this pylint warning

**account_budget_template/readme/DESCRIPTION.rst:1: [W7908(missing-newline-extrafiles), ]  Missing newline
account_budget_template/readme/CONTRIBUTORS.rst:1: [W7908(missing-newline-extrafiles), ]  Missing newline**

@oihane
Copy link
Contributor

oihane commented May 28, 2019

@dalonsod You should merge the commits you've done. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@dalonsod dalonsod force-pushed the 11.0-imp-account_budget_template branch from 07a7599 to cb41c7b Compare May 28, 2019 10:20
Copy link
Contributor

@oihane oihane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically reviewed LGTM

Copy link

@anajuaristi anajuaristi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
LGTM

Copy link

@lmiguens-solvos lmiguens-solvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit 7633c32 into OCA:11.0 Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants