Skip to content

Commit

Permalink
Take into account the remarks of Pedro:
Browse files Browse the repository at this point in the history
Use triple double quotes for docstring
Replace <openerp> by <odoo> in XML
Remove <data> tags in XML
Remove POT files
  • Loading branch information
alexis-via committed Oct 13, 2016
1 parent 5c2f2bd commit af45495
Show file tree
Hide file tree
Showing 13 changed files with 19 additions and 754 deletions.
444 changes: 0 additions & 444 deletions account_cutoff_base/i18n/account_cutoff_base.pot

This file was deleted.

10 changes: 5 additions & 5 deletions account_cutoff_base/models/account_cutoff.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ def _default_move_label(self):

@api.model
def _inherit_default_cutoff_account_id(self):
'''Function designed to be inherited by other cutoff modules'''
"""Function designed to be inherited by other cutoff modules"""
return None

@api.model
def _default_cutoff_account_id(self):
'''This function can't be inherited, so we use a second function'''
"""This function can't be inherited, so we use a second function"""
return self._inherit_default_cutoff_account_id()

cutoff_date = fields.Date(
Expand Down Expand Up @@ -141,7 +141,7 @@ def _prepare_move(self, to_provision):
movelines_to_create.append((0, 0, vals))
amount_total += amount

# add contre-partie
# add counter-part
counterpart_amount = amount_total * -1
movelines_to_create.append((0, 0, {
'account_id': self.cutoff_account_id.id,
Expand Down Expand Up @@ -342,9 +342,9 @@ class AccountCutoffMapping(models.Model):

@api.model
def _get_mapping_dict(self, company_id, cutoff_type='all'):
'''return a dict with:
"""return a dict with:
key = ID of account,
value = ID of cutoff_account'''
value = ID of cutoff_account"""
if cutoff_type == 'all':
cutoff_type_filter = ('all')
else:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data noupdate="1">
<odoo noupdate="1">


<record id="account_cutoff_multi_company_rule" model="ir.rule">
Expand All @@ -16,5 +15,4 @@
</record>


</data>
</odoo>
4 changes: 2 additions & 2 deletions account_cutoff_base/views/account_cutoff.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
-->

<odoo>
<data>


<menuitem id="cutoff_menu"
parent="account.menu_finance"
Expand Down Expand Up @@ -228,5 +228,5 @@
action="account_cutoff_mapping_action"
sequence="100"/>

</data>

</odoo>
4 changes: 2 additions & 2 deletions account_cutoff_base/views/company.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
-->

<odoo>
<data>


<record id="view_company_form" model="ir.ui.view">
<field name="name">cutoff.company.form</field>
Expand All @@ -20,5 +20,5 @@
</field>
</record>

</data>

</odoo>
279 changes: 0 additions & 279 deletions account_cutoff_prepaid/i18n/account_cutoff_prepaid.pot

This file was deleted.

3 changes: 1 addition & 2 deletions account_cutoff_prepaid/views/account_cutoff.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
-->

<odoo>
<data>


<!-- ACCOUNT CUTOFF -->
<record id="account_cutoff_tree" model="ir.ui.view">
Expand Down Expand Up @@ -163,5 +163,4 @@
sequence="20"/>


</data>
</odoo>
2 changes: 0 additions & 2 deletions account_cutoff_prepaid/views/company.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
-->

<odoo>
<data>


<record id="view_company_form" model="ir.ui.view">
Expand All @@ -21,5 +20,4 @@
</record>


</data>
</odoo>
Loading

0 comments on commit af45495

Please sign in to comment.