[12.0] Migrate accruals modules to v12 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alexis-via, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
sbidoul
reviewed
May 20, 2019
| elif cutoff_type == 'accrued_revenue': | ||
| journal = company.default_accrual_revenue_journal_id or\ | ||
| default_journal | ||
| return journal |
There was a problem hiding this comment.
Hi @alexis-via this method and associated default values are used in particular in account_invoice_accrual.
Can we preserve them?
cc/ @sbejaoui
There was a problem hiding this comment.
Hi @alexis-via,
I created a PR to add missing fields.
Can you check it please.
There was a problem hiding this comment.
I wanted to simplify all these additionnal settings and keep the ones that are really used by a majority of users... but your collegues convinced me :-(
…emove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy
….get('type', '-')
…de domains) On account.account, type must be <> 'view' and <> 'closed'
…a single warning left ! Add translation template files.
…revenues and for accrued expenses-revenues
Currently translated at 100,0% (20 of 20 strings) Translation: account-closing-10.0/account-closing-10.0-account_cutoff_accrual_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-10-0/account-closing-10-0-account_cutoff_accrual_base/de/
Currently translated at 100,0% (5 of 5 strings) Translation: account-closing-10.0/account-closing-10.0-account_cutoff_accrual_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-10-0/account-closing-10-0-account_cutoff_accrual_dates/de/
…ournal and number for accrual move and reversal
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (23 of 23 strings) Translation: account-closing-10.0/account-closing-10.0-account_cutoff_accrual_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-10-0/account-closing-10-0-account_cutoff_accrual_base/es/
Currently translated at 100.0% (23 of 23 strings) Translation: account-closing-10.0/account-closing-10.0-account_cutoff_accrual_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-10-0/account-closing-10-0-account_cutoff_accrual_base/fr/
Currently translated at 100.0% (5 of 5 strings) Translation: account-closing-10.0/account-closing-10.0-account_cutoff_accrual_dates Translate-URL: https://translation.odoo-community.org/projects/account-closing-10-0/account-closing-10-0-account_cutoff_accrual_dates/es/
Use account_analytic_id instead of account_analytic_code in views because the 'code' field of analytic account is not a required field
…ccount_cutoff_accrual_picking from v10 to v12 account_cutoff_base and account_cutoff_prepaid: Up-port improvements from v10 branch
Fix account_cutoff_base/readme/*
alexis-via
force-pushed
the
12-mig-accruals
branch
from
6baca90
to
b95dbdb
Compare
account_cutoff_accrual_picking: fix rst syntax
|
@alexis-via could you attend the tiny lint error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also up-port improvements in account_cutoff_base and account_cutoff_prepaid from v10 to v12, and add entries in accounting config page.