Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] - account_invoice_accrual migration to 12.0 #113

Closed
wants to merge 81 commits into from

Conversation

sbejaoui
Copy link
Contributor

No description provided.

Laetitia Gangloff and others added 30 commits May 14, 2019 10:21
… res_partner * Use default cutoff journal which is on company * Use accrual accounts defined on account_cutoff_accraul_base * Use accounts mapping which is implemented in account_cutoff_base * Adapt test suite
…k invoice if accrual entry is draft * Remove accrual in case of invoice's validation if accrual entry is draft and if entry genereted by the validation is on the same period as accrual * Otherwise, accrual entry is reversed
@oca-clabot
Copy link

Hey @sbejaoui, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 12.0 milestone May 14, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request May 14, 2019
6 tasks
@sbejaoui sbejaoui force-pushed the 12.0-mig-account_invoice_accrual branch from bbcf3dd to d10a757 Compare May 14, 2019 09:44
@sbejaoui sbejaoui force-pushed the 12.0-mig-account_invoice_accrual branch from d10a757 to 960ee48 Compare May 15, 2019 09:01
@sbejaoui sbejaoui force-pushed the 12.0-mig-account_invoice_accrual branch 2 times, most recently from 80771c3 to 2359e94 Compare June 20, 2019 12:20
"views/account_invoice_view.xml",
"wizard/account_move_accrue_view.xml",
],
"demo": [],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"demo": [],

<field name="name">account.move.accrue.form</field>
<field name="model">account.move.accrue</field>
<field name="arch" type="xml">
<form string="Create accrual journal entries" version="7.0">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<form string="Create accrual journal entries" version="7.0">
<form string="Create accrual journal entries">

@sbidoul
Copy link
Member

sbidoul commented Oct 16, 2020

@sbejaoui would you have a moment to look at this PR ? It would be nice to have it merged before the big migration to 14 starts. cc/ @alexis-via

@sbejaoui
Copy link
Contributor Author

@sbejaoui would you have a moment to look at this PR ? It would be nice to have it merged before the big migration to 14 starts. cc/ @alexis-via

This PR is blocked due to the dependency of account_invoice_accrual to account_reversal which was abandon and all the PRs are closed.

A new module took place account_document_reversal. I couldn't read all the discussions about this move. But I believe it's better to get rid of this dependency if the standard reverse feature do the job. Otherwise we need to adapt account_invoice_accrual to the new module.

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 3, 2022
@github-actions github-actions bot closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet