Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Allow to split by partner + group by tag group #122

Closed
wants to merge 1 commit into from

Conversation

vrenaville
Copy link

@vrenaville vrenaville commented Oct 30, 2019

  • Purpose
    Sometimes we want to split move line by partner, I have add a boolean to enable this feature.
    It also group by analytic tag group

@vrenaville vrenaville changed the title [IMP] Allow to split by partner [IMP] Allow to split by partner + group by tag group Nov 1, 2019
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks ok, however I guess we must have an option to enable/disable the grouping by analytic_tag_ids for retro compatibility, since it wasn't there before...

Moreover, can you please bump version number in __manifest__.py ?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 10, 2022
@github-actions github-actions bot closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants