New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] account_cutoff_base: Migration to 16.0 #213

Merged

OCA-git-bot merged 78 commits into OCA:16.0 from dzungtran89:16.0-account_cutoff_base

Feb 16, 2023

dzungtran89 commented Dec 5, 2022 •

edited

Loading

Needs

[16.0][FIX] copier update #212: for pre-commit fixes

Note:

I removed the groups from the company_id field is to avoid violating the check by the native, see here

dzungtran89 force-pushed the 16.0-account_cutoff_base branch from ca261b2 to 284e82c Compare

December 5, 2022 12:04

This was referenced Dec 6, 2022

Migration to version 16.0 #203

Open

[MIG] account_cutoff_accrual_picking: Migration to 16.0 #215

Closed

dzungtran89 marked this pull request as draft

December 7, 2022 06:02

dzungtran89 force-pushed the 16.0-account_cutoff_base branch from 284e82c to 331fbe9 Compare

December 7, 2022 07:31

dzungtran89 marked this pull request as ready for review

December 7, 2022 07:33

dzungtran89 force-pushed the 16.0-account_cutoff_base branch from 331fbe9 to ff4560b Compare

December 7, 2022 07:54

dzungtran89 mentioned this pull request

[MIG] account_cutoff_start_end_dates: Migration to 16.0 #216

Merged

Alexis de Lattre and others added 22 commits

December 8, 2022 14:04


          Initial check-in of my cut-off modules

2b1824f


          Coding style enhancements (osv.Model -> orm.Model, from . import xxx)

06c1931


          Add _prepare functions to allow to inherit before create

402e9be

Use assert
Remove .keys()
No space before colon
PEP8/Flake8 : getting closer to compliancy


          Forgot to move some code to the new _prepare function.

e2b16b7


          Remove the unnecessary "and True or False" after 'xxx' not in context…

d3026e1

….get('type', '-')


          Reduce flake8 warnings (cut lines and comments, space after coma insi…

38c21ec

…de domains)

On account.account, type must be <> 'view' and <> 'closed'


          My christmas present to the PEP8 fundamentalists : there is not even …

0f03aed

…a single warning left !

Add translation template files.


          all modules unported to odoo 8.0

e44cd61


          [MIG] move account_cutoff_base and account_cutoff_prepaid out of unpo…

…rted


          [MIG] account_cutoff: set installable=True

4f15f36


          [MIG] account_cutoff_prepaid 8.0

82f61fa


          [IMP] account_cutoff_prepaid: add hooks

65b9fc8

The signature of existing methods is preserved.


          [ADD][account_cutoff_base] Add multi-company record rule

999973c


          Add missing default oca icons

0608a9f


          [UPD] prefix versions with 8.0

cada7f3


          [MIG] Make modules uninstallable

01f3750


          [MIG] Rename manifest files

178cf8b


          Port account_cutoff_base and account_cutoff_prepaid to Odoo v9

d1954c3

Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid


          Add some hooks that are in 8.0

5217ce6


          Take into account the remarks of Pedro:

e5d97ed

Use triple double quotes for docstring
Replace <openerp> by <odoo> in XML
Remove <data> tags in XML
Remove POT files


          Migration of account_cutoff modules to 10.0

f087650


          [FIX] Bad attributes on m2m fields.

a8307eb

yankinmax and others added 6 commits

December 8, 2022 14:04


          [IMP] account_cutoff_base: pylint

32555d1


          [MIG] account_cutoff_base: Migration to 15.0

2f1673d


          account_cutoff_base: improve tree view of account.cutoff

0ab092a


          [UPD] Update account_cutoff_base.pot

291abcb


          Translated using Weblate (Spanish (Argentina))

2865fca

Currently translated at 100.0% (134 of 134 strings)

Translation: account-closing-15.0/account-closing-15.0-account_cutoff_base
Translate-URL: https://translation.odoo-community.org/projects/account-closing-15-0/account-closing-15-0-account_cutoff_base/es_AR/


          [IMP] account_cutoff_base: black, isort, prettier

ebd1021

dzungtran89 force-pushed the 16.0-account_cutoff_base branch from ff4560b to d302a89 Compare

December 8, 2022 07:08

dzungtran89 force-pushed the 16.0-account_cutoff_base branch from d302a89 to 1697b56 Compare

January 5, 2023 09:19

ivantodorovich approved these changes

View reviewed changes

ivantodorovich left a comment

Non-blocking comments

account_cutoff_base/models/account_cutoff_line.py Outdated

+                  company_currency_id = fields.Many2one(
+                      related="parent_id.company_currency_id",
+                      string="Company Currency",
+                      readonly=True,

ivantodorovich Jan 17, 2023

readonly is redundant here, in case you want to remove it

account_cutoff_base/models/account_cutoff_line.py

+                  )
+                  partner_id = fields.Many2one("res.partner", string="Partner", readonly=True)
+                  quantity = fields.Float(digits="Product Unit of Measure", readonly=True)
+                  price_unit = fields.Float(

ivantodorovich Jan 17, 2023

This could be a Monetary field

Contributor

alexis-via Feb 15, 2023

No. price_unit are not monetary fields for decimal precision reasons, cf https://github.com/odoo/odoo/blob/16.0/addons/sale/models/sale_order_line.py#L139
A price_unit can have a decimal precision higher than the currency precision.

account_cutoff_base/models/account_cutoff_line.py

+                      help="Price per unit (discount included) without taxes in the default "
+                      "unit of measure of the product in the currency of the 'Currency' field.",
+                  )
+                  price_origin = fields.Char(readonly=True)

ivantodorovich Jan 17, 2023

I fail to understand the purpose of this field, and why it is a Char but it's name suggests a price (thus it should be Float or Monetary)

Is this field even used? If so, what for? Should this be commented in the help attribute?

Contributor

alexis-via Feb 15, 2023

It's a small note field that indicate where the price has been taken from. So it contains an invoice number, a PO number or an SO number.

account_cutoff_base/models/account_cutoff_line.py Outdated

+                  price_origin = fields.Char(readonly=True)
+                  origin_move_line_id = fields.Many2one(
+                      "account.move.line", string="Origin Journal Item", readonly=True
+                  )  # Old name: move_line_id

ivantodorovich Jan 17, 2023

Maybe remove the # Old name: comments.
Seem like they're outdated by now

account_cutoff_base/models/account_cutoff_line.py

+                  origin_move_date = fields.Date(
+                      related="origin_move_line_id.move_id.date", string="Origin Journal Entry Date"
+                  )  # old name: move_date
+                  account_id = fields.Many2one(

ivantodorovich Jan 17, 2023

IMO, this model should have _check_company_auto = True, and a check_company on this account_id field.
(Maybe also other fields, if relevant)

account_cutoff_base/models/account_cutoff_tax_line.py Outdated

+                      ondelete="cascade",
+                      required=True,
+                  )
+                  tax_id = fields.Many2one("account.tax", string="Tax", required=True)

ivantodorovich Jan 17, 2023

check_company maybe?


          [MIG] account_cutoff_base: Migration to 16.0

54ecf1c

dzungtran89 force-pushed the 16.0-account_cutoff_base branch from 1697b56 to 54ecf1c Compare

January 18, 2023 04:19

Author

dzungtran89 commented Jan 18, 2023

@ivantodorovich , thank you for you comments, the PR has been updated

About the field price_origin, I'm not sure about its purpose tbh, it was initially added in the commit

simahawk mentioned this pull request

[16.0][MIG] account_cutoff_base: Migration to 16.0 #227

Closed

Contributor

alexis-via commented Feb 15, 2023

I'm preparing a PR on this PR, to take into account my comments and make a few improvements


          account_cutoff_base: forward-port source_move_state from v14

ba4db71

Revert price_unit to fields.Float() and price_origin to fields.Char()
Forward port post_cutoff_move on res.company from v14
Add ACLs for account readonly group
Remove duplicate-xml-fields, cf https://github.com/OCA/maintainer-tools/issues/558
Add name_get() on account.cutoff
Rename field move_label to move_ref
Update code to be able to add additional states (e.g. 'forecast' state introduced account_cutoff_start_end_dates)
Cleanup and improve views

Contributor

alexis-via commented Feb 15, 2023

Here it is: dzungtran89#1


          Merge pull request #1 from akretion/16.0-account_cutoff_base-fix-improve

4f46f35

[16.0] account_cutoff_base: improve your OCA PR

alexis-via approved these changes

View reviewed changes

OCA-git-bot added the approved label

Contributor

alexis-via commented Feb 16, 2023

/ocabot merge nobump

Contributor

OCA-git-bot commented Feb 16, 2023

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-213-by-alexis-via-bump-nobump, awaiting test results.

OCA-git-bot added the bot is merging ⏳ label

OCA-git-bot merged commit f0d754e into OCA:16.0

Contributor

OCA-git-bot commented Feb 16, 2023

Congratulations, your PR was merged at b2e2a7a. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels

Contributor

simahawk commented Feb 23, 2023

/ocabot migration account_cutoff_base

Contributor

simahawk commented Feb 23, 2023

@dzungtran89 next time, please, remove merge commits if you integrate other PRs. Thanks.

simahawk added this to the 16.0 milestone

Author

dzungtran89 commented Feb 23, 2023

hi @simahawk, well noted with thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment