Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][9.0] account multicurrency revaluation report #46

Conversation

grindtildeath
Copy link
Contributor

Depends on : #44

@grindtildeath grindtildeath force-pushed the 9.0-mig-account_multicurrency_revaluation_report branch 5 times, most recently from 8687d56 to d52c458 Compare February 7, 2017 11:22
@grindtildeath grindtildeath force-pushed the 9.0-mig-account_multicurrency_revaluation_report branch 2 times, most recently from 05d1258 to f762de1 Compare February 7, 2017 17:06
@pedrobaeza pedrobaeza mentioned this pull request Feb 7, 2017
7 tasks
@grindtildeath grindtildeath force-pushed the 9.0-mig-account_multicurrency_revaluation_report branch 3 times, most recently from 34a133d to fa4cdd1 Compare February 8, 2017 15:16
@grindtildeath grindtildeath force-pushed the 9.0-mig-account_multicurrency_revaluation_report branch 3 times, most recently from 10a7382 to 5594c2d Compare February 8, 2017 16:55
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also delete mako template

@@ -0,0 +1,106 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To move in parent folder

<record id="bank_journal_usd" model="account.journal">
<field name="name">Bank Journal USD</field>
<field name="code">BJ USD</field>
<field name="type">bank</field>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set currency_id in this file instead of doing it in unit tests ?

@grindtildeath grindtildeath force-pushed the 9.0-mig-account_multicurrency_revaluation_report branch from b4fce3d to 1f6ff94 Compare April 4, 2017 16:03
@grindtildeath grindtildeath force-pushed the 9.0-mig-account_multicurrency_revaluation_report branch from 1f6ff94 to e2a2bce Compare June 30, 2017 09:58
@grindtildeath grindtildeath changed the title [WIP][MIG][9.0] account multicurrency revaluation report [MIG][9.0] account multicurrency revaluation report Jun 30, 2017
@grindtildeath
Copy link
Contributor Author

Please remove work in progress label and add needs review.
Ping @fclementic2c @elicoidal

@grindtildeath grindtildeath force-pushed the 9.0-mig-account_multicurrency_revaluation_report branch from e2a2bce to 6bacf34 Compare June 30, 2017 15:32
@grindtildeath grindtildeath force-pushed the 9.0-mig-account_multicurrency_revaluation_report branch from 6bacf34 to 00a6548 Compare July 3, 2017 13:40
@fclementic2c
Copy link
Member

ok for me
👍

@fclementic2c fclementic2c merged commit 0356e15 into OCA:9.0 Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants