[11.0][mig][account_fiscal_year_closing] WIP #58
Conversation
* Included template mechanism * Remove unused files * Fix behaviors * Some refactoring * Complete features
|
@pedrobaeza Seems to me that the bug odoo/odoo#20163 will not have an easy fix. I propose to continue with the approach of v9 and v10. |
|
Well, as said by them, the workaround should work, so let's give them a bit more time... If not , we can always easily switch back to the old mechanism. |
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| import logging | ||
| from openerp import _, api, exceptions, fields, models |
There was a problem hiding this comment.
Maybe you can replace all from openerp ... to from odoo ...
Or execute find . -type f -name '*.py' | xargs sed -i 's/from openerp/from odoo/g' on root.
| <field name="company_id" groups="base.group_multi_company"/> | ||
| </group> | ||
| </group> | ||
| <group string="Moves configuration"> |
There was a problem hiding this comment.
Replace string selectors by name.
<group name="Moves configuration">
There was a problem hiding this comment.
It shouldn't be replaced, but complemented:
<group string="Moves configuration" name="moves_configuration"/>
| <field name="move_type"/> | ||
| </group> | ||
| </group> | ||
| <group string="Accounts mapping"> |
There was a problem hiding this comment.
Replace string selectors by name.
| </tree> | ||
| </field> | ||
| </group> | ||
| <group string="Accounts closing types"> |
There was a problem hiding this comment.
Replace string selectors by name.
| <field name="calculation_date"/> | ||
| </group> | ||
| </group> | ||
| <group string="Moves configuration"> |
There was a problem hiding this comment.
Replace string selectors by name.
| <field name="move_type"/> | ||
| </group> | ||
| </group> | ||
| <group string="Accounts mapping"> |
There was a problem hiding this comment.
Replace string selectors by name.
| </tree> | ||
| </field> | ||
| </group> | ||
| <group string="Accounts closing types"> |
There was a problem hiding this comment.
Replace string selectors by name.
JordiBForgeFlow
force-pushed
the
11.0-mig-account_fiscal_year_closing
branch
from
cc21705
to
ffdad6d
Compare
JordiBForgeFlow
force-pushed
the
11.0-mig-account_fiscal_year_closing
branch
from
ffdad6d
to
e817d69
Compare
| @@ -0,0 +1,5 @@ | |||
| # -*- coding: utf-8 -*- | |||
| @@ -0,0 +1,27 @@ | |||
| # -*- coding: utf-8 -*- | |||
| @@ -0,0 +1,6 @@ | |||
| # -*- coding: utf-8 -*- | |||
| @@ -0,0 +1,76 @@ | |||
| # -*- coding: utf-8 -*- | |||
| @@ -0,0 +1,92 @@ | |||
| # -*- coding: utf-8 -*- | |||
| @@ -0,0 +1,31 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
Closing as no need of this one finally. |
|
@pedrobaeza can you reopen this as of thread Functional Question: Year End Closing in Odoo (OPEJ) in mailing list? I based the v. 12.0 on this one. |
|
No, you should do a new PR based on this PR, as the original contributor is not interested anymore in it. |
|
ah ok |
@pedrobaeza |
|
No need of fiscal year closing since v9. |
|
@pedrobaeza as of your reply on contributor mailing list I opened #129 (and #134) in this repo, if preferable I'll move it on Italian localization. |
|
Yes, but the general reply still is that is not needed. You insist on putting it, then you continue with the PR, but better to not confuse others believing that the module is needed in a general way. |
|
I agree, this module is useful only if user is absolutely sure that laws in his country require it. |
Upgrade base image - fix CVE-2017-8291
WIP. Seems that issue odoo/odoo#20163 was not completely resolved. I am asking to reopen.