11.0 mig account_multicurrency_revaluation #64
Conversation
…rency_revaluation
…te to fix translation extraction
- one for the business feature (account_multicurrency_revaluation) - one for the report feature (account_multicurrency_revaluation_report) I move the report feature to a dedicated module because else the whole module could not be upgraded because of this pull request: OCA/webkit-tools#10 Indeed, the module previously depended on the module base_headers_webkit. Now, only the module for the report (account_multicurrency_revaluation_report) will depend on it. The reference to the currency type has been removed because it has been removed from the core addons in v8. The code is not fully ported to the new API yet.
…folder and the views into a new 'views' folder
…PI consistency (mainly the use of the context). New README.rst file.
…E.rst files because this file is for individual
…ix the onchange mechanism. Small typo
|
@OleksandrPaziuk Please ping me when travis is green so I can test on runbot. Thanks (and happy new year by the way) |
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/89/10.0 |
|
|
||
|
|
||
| class AccountConfigSettings(models.TransientModel): | ||
| _inherit = 'account.config.settings' |
There was a problem hiding this comment.
AFAIK this model does not exist anymore. res.config.settings holds them all
| # Small class that avoid to override account account object | ||
| # only for pure perfomance reason. | ||
| # Browsing an account account object is not efficient | ||
| # beacause of function fields |
| # only for pure perfomance reason. | ||
| # Browsing an account account object is not efficient | ||
| # beacause of function fields | ||
| # This object aim to be easly transpose to account account if needed |
| """Get all line account move line that are need on report for current | ||
| account. | ||
| """ | ||
| sql = """Select res_partner.name, |
| revaluation_date = fields.Date( | ||
| string='Revaluation Date', | ||
| required=True, | ||
| default=_get_default_revaluation_date |
There was a problem hiding this comment.
use lambda to proxy the method
| domain="[('type','=','general')]", | ||
| help="You can set the default journal in company settings.", | ||
| required=True, | ||
| default=_get_default_journal_id |
| help="This label will be inserted in entries description. " | ||
| "You can use %(account)s, %(currency)s and %(rate)s keywords.", | ||
| required=True, | ||
| default="%(currency)s %(account)s " |
There was a problem hiding this comment.
same, delegate to a method
| @return: ids of created move_lines | ||
| """ | ||
|
|
||
| def create_move_and_lines(amount, debit_account_id, credit_account_id, |
There was a problem hiding this comment.
move this to a static method
| account_obj = self.env['account.account'] | ||
|
|
||
| company = self.journal_id.company_id or self.env.user.company_id | ||
| if (not company.revaluation_loss_account_id and |
There was a problem hiding this comment.
split this to _check_company static method.
|
@fclementic2c Travis GREEN! |
|
@OleksandrPaziuk I'd squash also some small commits among these: /cc @yvaucher @grindtildeath reviews welcome 😉 |
|
I did a test on this PR runbot. I did not setup default accounts in the settings and I got a nasty message when I clicked on Validate button from the wizard : Can you catch this error with a nicer message please? Error: Traceback (most recent call last): |
| """ | ||
| Get last date of previous fiscalyear | ||
| """ | ||
| return fields.date.today() |
There was a problem hiding this comment.
Is this working as intended? Otherwise docstring is wrong
There was a problem hiding this comment.
Docstring is wrong. I should have changed it while migrating to v9, but it went through.
As fiscal year don't exist anymore, the default should be today.
|
@fclementic2c I replace |
|
@OleksandrPaziuk Thanks the fix is ok. I have another bug now: I have launched the unrealized gain/loss report (after I have successfully generated revaluation entries on the 31/12/2017) but I get this error: Error: Traceback (most recent call last): |
|
@OleksandrPaziuk @fclementic2c Seems to be related to the fact that they removed the 'report' service : odoo/odoo@c23ef9a#diff-03542f2676ca18278ea62cb40f5a2261 and the issue is very similar to this one : odoo/odoo#21244 but I have no clue on how to fix the problem :( |
| data, | ||
| ), | ||
| } | ||
| return self.env['report'].render(self._name[7:], docargs) |
There was a problem hiding this comment.
This won't work in Odoo 11.0
What is needed is to use the new report structure. report module has been splitted between web and base modules.
The good new is that it is now pretty simple to render a specific report. You need to use the xmlid:
self.env.ref('foo_report_xmild').render(recordset, data=data)Thus in your case, try:
self.env.ref('account_multicurrency_revaluation.curr_unrealized').render(docs)
| @@ -30,6 +30,31 @@ class AccountAccount(models.Model): | |||
| "balance", | |||
| } | |||
|
|
|||
| def init(self): | |||
| @api.onchange('user_type_id') | ||
| def _onchange_user_type_id(self): | ||
| for rec in self: | ||
| if rec.user_type_id.id in rec._get_revaluation_account_types(): |
There was a problem hiding this comment.
call self._get_revaluation_account_types at the top, not for any records.
| domain="[('currency_revaluation', '=', True)]" | ||
| string='Accounts', | ||
| domain="[('currency_revaluation', '=', True)]", | ||
| default=lambda rec: rec._default_account_ids(), |
| return self.env.ref( | ||
| 'account_multicurrency_revaluation.' | ||
| 'action_report_currency_unrealized' | ||
| ).report_action(docids, config=False) |
There was a problem hiding this comment.
for your future self you might to put a comment about that config arg
| "report/report.xml", | ||
| "report/unrealized_currency_gain_loss.xml", | ||
| ], | ||
| "tests": [ |
| account_id, currency_id, partner_id = \ | ||
| line['id'], line['currency_id'], line['partner_id'] | ||
|
|
||
| accounts.setdefault(account_id, {}) |
There was a problem hiding this comment.
you can use collections.defaultdict 😉
There was a problem hiding this comment.
I'm pretty sure nesting defaultdicts will make it less readable :\
|
|
||
| class ShellAccount(object): | ||
|
|
||
| # Small class that avoid to override account account object |
There was a problem hiding this comment.
move this to docstring following PEP257
| fields.date.today().strftime(DATE_FORMAT)) | ||
| self.assertEqual(wizard.journal_id, self.reval_journal) | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
better to:
- inherit from SavepointCase
- move setUp code to setUpClass
- move this method at the top
…lticurrency_revaluation
|
@yvaucher @grindtildeath @simahawk |
|
I'm not sure this should have been merged so, there are still a few things to improve IMO 😕 |
| <label string="Odoo will generate exchange rate difference entries for each account set as 'Allow Currency revaluation'. | ||
| If the account type is payable or receivable : 1 entry will be generated per account/currency/partner | ||
| for other account type : 1 entry will be generated per account/currency | ||
| You can check details of calculation thanks to the Print Currency unrealized report in the generic reports."/> |
There was a problem hiding this comment.
Please add '.' to separate sentences.
| """ | ||
| Get last date of previous fiscalyear | ||
| """ | ||
| return fields.date.today() |
There was a problem hiding this comment.
Docstring is wrong. I should have changed it while migrating to v9, but it went through.
As fiscal year don't exist anymore, the default should be today.
| <field name="arch" type="xml"> | ||
| <xpath expr="//div[@id='invoicing_settings']" position="after"> | ||
| <h2>Multicurrency revaluation</h2> | ||
| <div class="row mt16 o_settings_container" id="multicurrency_revaluation_settings"> |
There was a problem hiding this comment.
IMO this whole div should be reworked that it integrates nicely with the new settings wizard. (i.e. company dependent fields, grid for accounts, etc). Also I think we should hide the whole section if the user doesn't have the security group.
| _("No revaluation or provision account are defined" | ||
| " for your company.\n" | ||
| "You must specify at least one provision account or" | ||
| " a couple of provision account.") |
There was a problem hiding this comment.
I would add :
"You must specify at least one provision account or a couple of provision account in the accounting settings"
| <field name="currency_id" ref="base.GBP"/> | ||
| </record> | ||
| <record model="res.currency.rate" id="currency_rate_gbp_2017_03"> | ||
| <field name="name">2017-03-15</field> |
There was a problem hiding this comment.
Could you change all the names so the year is automatically the actual one ? Otherwise it's a pain to test it manually.
Test case would have to be adapted as well.
No description provided.