Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module to manage financial reports in OCA #182

Merged
merged 2 commits into from Apr 26, 2016

Conversation

lepistone
Copy link
Member

No description provided.

@lepistone
Copy link
Member Author

We are wondering if it's better to start with an empty one like this or if we want to rename account_financial_report_webkit.

Ideas?

@pedrobaeza
Copy link
Member

I think it's better to start from scratch, and maybe copy/paste some code (crediting authors) if needed. The architecture of account_financial_report_webkit is very complicated for the task per se.

@lepistone
Copy link
Member Author

I agree with you pedro: starting with a rename is a can of worms, and we don't get something working quickly. Thanks!

@astirpe
Copy link
Member

astirpe commented Apr 26, 2016

I agree, could we have it merged soon, even if it's just a skeleton? This way we all can start to check it out.

@pedrobaeza
Copy link
Member

@astirpe, you don't need to merge it. You can clone just right now:

git clone https://github.com/damdam-s/account-financial-reporting -b 9.0-sorrento-ledger

@lepistone
Copy link
Member Author

@pedrobaeza we decided to have a special common branch for the sprint, the target of this PR, and all use this! Not a real merge to 9.0 of course.
This will help us all work together at the same time.

@pedrobaeza
Copy link
Member

pedrobaeza commented Apr 26, 2016

Yeah, of course, you can create a branch and make all code sprint participants member of it, so everyone can push to it. Good choice!

@lepistone
Copy link
Member Author

Great! I'm merging this so others pick it up. cc @OpenCode @andrea4ever @CiroBoxHub

@lepistone lepistone merged commit 92074c4 into OCA:9.0-sorrento Apr 26, 2016
@coveralls
Copy link

coveralls commented Apr 26, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 75f377d on damdam-s:9.0-sorrento-ledger into be32b21 on OCA:9.0-sorrento.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants