Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[9.0] mis_builder Sorrento #189
This is the work done on mis_builder at the Sorrento Sprint.
Thanks to all who contributed code and ideas! It was a great event.
This branch should be usable as is, although not yet perfect.
Then let's review and merge fast so the work in account_financial_report_qweb that depends on this can continue.
@sbidoul fixed, now you have the last messages here
Ok, so now I consider the code is much cleaner and maintainable with a proper separation of concerns:
There is full feature parity across the 3 renderings.
For more information on new features and fixes compared to the v8 version, see the changelog: https://github.com/oca-sorrento/account-financial-reporting/blob/022b8a8998d7f38fb40f0e82185211b2f044ab62/mis_builder/CHANGES.rst
The test coverage is reasonably complete (78%, with the AccoutingExpressionProcessor fully tested except some error cases).
I still have plenty of ideas for improvements and features, but I'll stop here for now!
Should we fix the duplicated csv id?