[9.0] mis_builder Sorrento #189

sbidoul · 2016-04-29T10:19:18Z

This is the work done on mis_builder at the Sorrento Sprint.

Thanks to all who contributed code and ideas! It was a great event.

This branch should be usable as is, although not yet perfect.

Sprinters (in particular @adrienpeiffer @sebastienbeau @gfcapalbo), feel free to commit your last small changes here if any.

Then let's review and merge fast so the work in account_financial_report_qweb that depends on this can continue.

Code is simpler too but here we really lose functionality.

…ompatible with Odoo enterprise edition.

…eport_xlsx.

…omputation error

…rt button in the widget.

…ce instead of report instance settings.

…ow setings button

…h the debit and the credit are zero and balances among which debit and credit nullify

sbidoul · 2016-05-17T10:24:44Z

@moylop260 I'm still lost with the hanging indent errors.

I installed the latest flake8 locally in a fresh virtualenv and run it without errors. Do you have a suggestion?

ThomasBinsfeld · 2016-05-17T10:34:28Z

@sbidoul Launch flake8 with --ignore ("flake8 --ignore E128 " for example) and it will show the under/over-indented lines

sbidoul · 2016-05-17T11:05:56Z

@ThomasBinsfeld thanks! I would not have thought ignoring an error would raise others.

coveralls · 2016-05-17T11:15:23Z

Coverage remained the same at 77.77% when pulling 022b8a8 on oca-sorrento:9.0-mis_builder-sorrento into be32b21 on OCA:9.0.

sbidoul · 2016-05-17T12:13:47Z

Ok, so now I consider the code is much cleaner and maintainable with a proper separation of concerns:

mis_report.py: the core module providing the report templates and computation logic relying on a bunch of lower level features (aep, accounting_none, simple_array, mis_report_style)
mis_report_instance.py: providing instanciation of report templates for given time periods
the various renderings: widget, qweb-pdf, xslx

There is full feature parity across the 3 renderings.

For more information on new features and fixes compared to the v8 version, see the changelog: https://github.com/oca-sorrento/account-financial-reporting/blob/022b8a8998d7f38fb40f0e82185211b2f044ab62/mis_builder/CHANGES.rst

The test coverage is reasonably complete (78%, with the AccoutingExpressionProcessor fully tested except some error cases).

I still have plenty of ideas for improvements and features, but I'll stop here for now!

Happy reviewing!

moylop260 · 2016-05-17T14:00:26Z

Should we fix the duplicated csv id?

mis_builder/__init__.py:1: [W7906(duplicate-id-csv), ] Duplicate id "access_mis_report_kpi_expression" in ir.model.access.csv file
mis_builder/__init__.py:1: [W7906(duplicate-id-csv), ] Duplicate id "access_mis_report_subkpi" in ir.model.access.csv file
mis_builder/__init__.py:1: [W7906(duplicate-id-csv), ] Duplicate id "access_mis_report_style" in ir.model.access.csv file

sbidoul · 2016-05-17T14:12:27Z

@moylop260 perhaps, perhaps. I don't know (yet) what this warning means.

moylop260 · 2016-05-17T14:29:48Z

Help me to use a clearer message for the following case:

duplicate-id-csv

moylop260 · 2016-05-17T14:50:44Z

If you have a proposal for this message you could comment here: OCA/pylint-odoo#32

sbidoul · 2016-05-17T15:37:48Z

@moylop260 the message is just fine. Useful check, thanks! Fixed.

coveralls · 2016-05-17T15:46:02Z

Coverage remained the same at 77.77% when pulling 910cd1e on oca-sorrento:9.0-mis_builder-sorrento into be32b21 on OCA:9.0.

moylop260 · 2016-05-17T15:57:11Z

Thanks @sbidoul
👍

lepistone · 2016-05-23T11:50:18Z

mis_builder/datas/ir_cron.xml

+    <data noupdate="1">
+
+        <record id="ir_cron_crm_action" model="ir.cron">
+            <field name="name">Vaccum temporary report</field>


…sh 0 from null in initial balances This should be slightly on the safer side. Ideally, this rounding precision should come from the kpi style (which defaults to the report style), but that would be a lot of code for little benefits.

…initial balances are null or 0

coveralls · 2016-05-24T06:36:40Z

Coverage remained the same at 77.786% when pulling 5319238 on oca-sorrento:9.0-mis_builder-sorrento into be32b21 on OCA:9.0.

lepistone · 2016-05-24T08:41:08Z

mis_builder/models/simple_array.py

+# -*- coding: utf-8 -*-
+# © 2014-2015 ACSONE SA/NV (<http://acsone.eu>)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+""" A trivial immutable array that supports basic arithmetic operations.


This is somewhat like numpy.array without pulling all of numpy, am I right?

@lepistone it is. I kind of thought pulling numpy was not appropriate 😉
In the end SimpleArray does a bit more wrt exception handling (DataError).

lepistone · 2016-05-24T08:51:26Z

Great work, thanks! 👍

I think I can merge this!

sbidoul and others added 30 commits April 29, 2016 12:11

Migrate aep to 9.0: periods are gone, so far, so good

b1a5dc5

add v9 thoughts in the readme

68c48dd

no more parent_id, no more consolidation children

f0fe48b

Code is simpler too but here we really lose functionality.

no more fiscal period, no more root account

cebd882

Not really the same js in 9.0 ...

4841585

[mis_builder] First installable version in 9.0 ! Enjoy !

0d32c70

Bump version number

816dfc1

[FIX] remove unused import

43edb9a

[CHG][mis_builder] Use base_report_xlsx instead of report_xls

02e6f89

[FIX][mis_builder] Change parent menu for MIS report template to be c…

3cfc220

…ompatible with Odoo enterprise edition.

[IMP][mis_builder] Remove unnecessary code

58ec065

[FIX][mis_builder] Fix test suite.

38075ac

pep8 & co

1b11a87

[CHG][mis_builder] According with the rename of base_report_xlsx to r…

b4fc7b1

…eport_xlsx.

[FIX] Flake8 issues

293ba89

[FIX] Bad modification

1c094b3

[IMP] add prefixes. comes from PR OCA#145

d526bb9

mis_builder : in compute do not set val in localdict if there was a c…

a4301c1

…omputation error

[IMP][mis_builder] MIS Builder widget improvement, add print and expo…

350c996

…rt button in the widget.

[IMP][mis_builder] use get_context method in drilldown method

592ee64

[IMP][mis_builder] Improve buttons position

2fd5a39

[IMP][mis_builder] Improve usability : Display directly report instan…

d61a88d

…ce instead of report instance settings.

[IMP][mis_builder] Add whitespace between buttons and table.

1251399

[IMP][mis_builder] Check if current user is in accountant group to sh…

f6fd1c8

…ow setings button

[FIX][mis_builder] Fix the creation of a new mis.report.instance.

cafbdda

[ADD] AccountingNone (singleton) to differentiate balances among whic…

8e4e046

…h the debit and the credit are zero and balances among which debit and credit nullify

[FIX] reset permissions that should not have changed

261fd68

[IMP] improve AccountingNone wrt comparisons mainly

f334f31

Add copyright header and __all__ to accounting_none.py

2908516

[FIX] fix comparison rendering in presence of AccountingNone

16678d8

[IMP] mis_builder: more lint

022b8a8

[FIX] mis_builder: duplicate record ids in ACLs

910cd1e

lepistone mentioned this pull request May 23, 2016

Made web_widget_color installable and remove the search field. OCA/web#270

Closed

lepistone reviewed May 23, 2016
View reviewed changes

sbidoul added 4 commits May 23, 2016 17:52

[FIX] mis_builder: better xmlid and name for vacuum cron

5569b6b

[FIX] mis_builder: typo in docstring

f4a9b0d

[IMP] mis_builder: use company currency decimal place in deciding if …

5319238

…initial balances are null or 0

lepistone reviewed May 24, 2016
View reviewed changes

lepistone merged commit 568fbb6 into OCA:9.0 May 24, 2016

moylop260 mentioned this pull request Jun 10, 2016

[IMP] Avoid console.log in JS code via flake8 OCA/maintainer-quality-tools#335

Closed

moylop260 mentioned this pull request Jul 26, 2016

Add ESLint to the bots OCA/maintainer-quality-tools#344

Closed

pedrobaeza mentioned this pull request Sep 24, 2016

Migration to version 9.0 #125

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0] mis_builder Sorrento #189

[9.0] mis_builder Sorrento #189

sbidoul commented Apr 29, 2016

sbidoul commented May 17, 2016

ThomasBinsfeld commented May 17, 2016

sbidoul commented May 17, 2016

coveralls commented May 17, 2016 •

edited

sbidoul commented May 17, 2016

moylop260 commented May 17, 2016 •

edited

sbidoul commented May 17, 2016

moylop260 commented May 17, 2016 •

edited

moylop260 commented May 17, 2016

sbidoul commented May 17, 2016

coveralls commented May 17, 2016 •

edited

moylop260 commented May 17, 2016

lepistone May 23, 2016

coveralls commented May 24, 2016 •

edited

lepistone May 24, 2016

sbidoul May 24, 2016

lepistone May 24, 2016

lepistone commented May 24, 2016

[9.0] mis_builder Sorrento #189

[9.0] mis_builder Sorrento #189

Conversation

sbidoul commented Apr 29, 2016

sbidoul commented May 17, 2016

ThomasBinsfeld commented May 17, 2016

sbidoul commented May 17, 2016

coveralls commented May 17, 2016 • edited

sbidoul commented May 17, 2016

moylop260 commented May 17, 2016 • edited

sbidoul commented May 17, 2016

moylop260 commented May 17, 2016 • edited

moylop260 commented May 17, 2016

sbidoul commented May 17, 2016

coveralls commented May 17, 2016 • edited

moylop260 commented May 17, 2016

lepistone May 23, 2016

Choose a reason for hiding this comment

coveralls commented May 24, 2016 • edited

lepistone May 24, 2016

Choose a reason for hiding this comment

sbidoul May 24, 2016

Choose a reason for hiding this comment

lepistone May 24, 2016

Choose a reason for hiding this comment

lepistone commented May 24, 2016

coveralls commented May 17, 2016 •

edited

moylop260 commented May 17, 2016 •

edited

moylop260 commented May 17, 2016 •

edited

coveralls commented May 17, 2016 •

edited

coveralls commented May 24, 2016 •

edited