Migration of account_chart_report to V8 #54
Conversation
| 'Chart of Accounts', | ||
| help='Select Charts of Accounts', | ||
| required=True, | ||
| domain=domain_char_account) |
There was a problem hiding this comment.
You can put directly the domain between quotes instead of making that weird trick.
| res = self.read(cr, uid, ids, context=context)[0] | ||
| @api.multi | ||
| def print_report(self, data): | ||
| res = self.read()[0] |
There was a problem hiding this comment.
instead of using read, you can directly get the value.
(I assume self can only be a single ChartOfAccountsReport)
self.chart_account_id.id
|
Please rebase this PR to fix travis build. |
|
Done |
|
Changes Unknown when pulling 83abecc on JehoG:8.0 into * on OCA:8.0*. |
| required=True, | ||
| domain=domain_char_account), | ||
| } | ||
| chart_account_id = fields.Many2one('account.account', |
There was a problem hiding this comment.
Please remove the whitespace at EOL
./account_chart_report/wizard/account_report_chart_of_account.py:30:58: W291 trailing whitespace
|
Changes Unknown when pulling 8312cc1 on JehoG:8.0 into * on OCA:8.0*. |
| } | ||
| chart_account_id = fields.Many2one( | ||
| 'account.account', | ||
| 'Chart of Accounts', |
There was a problem hiding this comment.
./account_chart_report/wizard/account_report_chart_of_account.py:31:13: E126 continuation line over-indented for hanging indent
Please remove 4 spaces of indent
|
@yvaucher @pedrobaeza Is this PR needs some other modifications? |
|
👍 for me |
|
👍 |
|
Before merging, can you please extract the description to a README.rst file and remove it from the manifest (new possibility in v8)? |
|
Changes Unknown when pulling de0e1f1 on JehoG:8.0 into * on OCA:8.0*. |
|
Thanks for the changes. It's missing the OCA disclaimer part, but I'll add it in a later commit. |
Migration of account_chart_report to V8
Migration of account_chart_report to V8
[IMP] set statement line on old account move for bank statement report
Move fr.po in account_move_line_search_extension to __unported__
Some functions of /report/chart_of_accounts.py aren't ported to V8 API because they can't accept the decorators (no browse attribute error).
If there's a way, I'll be happy to make the changes.