[12.0] mig account_financial_report #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @eLBati, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
@feketemihai @mpanarin see #559 (comment) Could you tell me which email should I set ? |
|
Have you included all the mentioned PRs? |
|
@qgroulard I was not able to apply 8796d6f |
|
@pedrobaeza Merged PRs are incuded. |
|
OK, thanks for gathering this. Let's push for have it in v12! |
eLBati
force-pushed
the
12.0-mig-account_financial_report-2
branch
from
75994a9
to
097a9ab
Compare
|
@mpanarin thanks, fixed |
eLBati
force-pushed
the
12.0-mig-account_financial_report-2
branch
4 times, most recently
from
ca1c60b
to
a444644
Compare
eLBati
force-pushed
the
12.0-mig-account_financial_report-2
branch
3 times, most recently
from
be76362
to
f642dc3
Compare
|
@mreficent done, thanks. I have a problem with About translations, I updated |
|
my opinion for PDF reports necessary inherit_id="web.report_assets_common" |
eLBati
force-pushed
the
12.0-mig-account_financial_report-2
branch
from
f642dc3
to
7130857
Compare
|
@tate11 thanks! Fixed. This is now ready for me |
MiquelRForgeFlow
approved these changes
Jun 6, 2019
pedrobaeza
reviewed
Jun 7, 2019
eLBati
force-pushed
the
12.0-mig-account_financial_report-2
branch
2 times, most recently
from
7c8c6ad
to
851038e
Compare
* Fix account group level computation
Depends was not correct for recomputing when needed + better algorithm
* Make hide details on 0 work properly
* Passing values to general ledger was stripping some correct records
* Computed field for hiding lines doesn't have proper dependencies nor is not
taking into account float currency accuracy
Currently translated at 21.5% (67 of 312 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/it/
Currently translated at 99.7% (311 of 312 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/
* Fix wizards for proper multicompany behaviour. * Fix layout issue
- minor usability fixes for multicompany - improve performance of general ledger using a new index
Currently translated at 100.0% (328 of 328 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/
Currently translated at 85.7% (276 of 322 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/de/
Currently translated at 100.0% (323 of 323 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/
Currently translated at 22.3% (72 of 323 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/it/
* Move to less files to compile variables * hide contacts on partner * Add reports to res partner actions * initialize wizard from context * initialize wizard by current fiscal year
Currently translated at 100.0% (323 of 323 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/
- _description in account_financial_report_abstract - _description in vat.report.wizard - Two fields using same label 'Accounts' in account.group - Two fields using same label 'Account' in report_journal_ledger_move_line - Two fields using same label 'Partner' in report_journal_ledger_move_line - Two fields using same label 'Accounts' in report_trial_balance_account - Two fields using same label 'Tax' in report_vat_report_taxtag - Two fields using same label 'Tax' in report_vat_report_tax - Two fields using same label 'Filter accounts' in general.ledger.report.wizard
[IMP] Reformated one query to avoid one sql injection warning message - but no sql injection was possible here
* Move back to CSS and FIX
NameError: variable @odoo-view-background-color is undefined in - on line 99, column 23:
98 .o_account_financial_reports_page {
99 background-color: @odoo-view-background-color;
100 color: @odoo-main-text-color;
* Porting: parent_left does not exist anymore. Using parent_path + account code to sort report lines
* FIX js error with date object not converted to string while clicking on initial balance amount
See https://user-images.githubusercontent.com/1033131/58337566-5d525c80-7e46-11e9-913a-3c3e0115fb3e.gif
* IMP style and metadata
* FIX tests about new date format and partner_id computed field of account.move
* FIX errors like
2019-06-03 16:11:51,406 17857 ERROR dev_12_account_financial_report odoo.sql_db: bad query: b"\nDELETE FROM 'report_vat_report_tax'\nWHERE COALESCE(\n write_date, create_date, (now() at time zone 'UTC'))::timestamp\n < ((now() at time zone 'UTC') - interval '3600.0 seconds')\n"
ERROR: syntax error at or near "'report_vat_report_tax'"
LINE 2: DELETE FROM 'report_vat_report_tax'
^
* IMP translation template and IMP Italian translation
* Remove useless comments
* Use AsIs to avoid SQL injection
* Use fields.Date methods
* Remove useless data from tests
* Improve comments
* Fix wizard.multi.charts.accounts
* Move _get_partner_ids_domain to abstract wizard
* Refactor default partners in wizard to use recordsets
* Improve js style
pedrobaeza
force-pushed
the
12.0-mig-account_financial_report-2
branch
from
efc1088
to
910d62e
Compare
pedrobaeza
approved these changes
Jun 13, 2019
|
Thanks all for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuilt branch from 11.0 and applied commits from #509
TODO