[12.0][FIX] partner_statement: Covers the case where name and ref are strictly the same in account_move_line #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvinh
changed the title
cvinh
changed the title
cvinh
force-pushed
the
12.0-fix_partner_statement_name_ref
branch
from
0e48750
to
4ffef05
Compare
|
This looks wrong to me. It appears to break the case where they aren't the same, however one is in the other, and you would have both appear. |
|
and rebase |
|
Superseded by #652. |
MiquelRForgeFlow
suggested changes
Jan 31, 2020
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following use case :
If the fields name and ref are the same in account_move_line, nothing appears in the description column of the reports