[IMP] account_tax_balance: Optimized computation of move type #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
force-pushed
the
9.0-account_tax_balance-move_type_compute_optimized
branch
from
fd24356
to
01c0ea1
Compare
|
What happens with travis? 😵 |
pedrobaeza
reviewed
Dec 13, 2019
yajo
force-pushed
the
9.0-account_tax_balance-move_type_compute_optimized
branch
from
01c0ea1
to
e6b134c
Compare
|
All done. |
pedrobaeza
approved these changes
Dec 13, 2019
|
If you rebase, we get a green CI for better display |
yajo
force-pushed
the
9.0-account_tax_balance-move_type_compute_optimized
branch
from
e6b134c
to
57b2bca
Compare
|
Rebased. |
yajo
force-pushed
the
9.0-account_tax_balance-move_type_compute_optimized
branch
from
57b2bca
to
39142d7
Compare
|
Fix tests |
Reduced complexity based on `read_group`. This method was prefetching a lot and doing many slow operations. Executing in a real database for 197361 recs. took 14 minutes before and 1:36 minutes now. @Tecnativa TT18838
yajo
force-pushed
the
9.0-account_tax_balance-move_type_compute_optimized
branch
from
39142d7
to
f3ddb4f
Compare
|
Done, thanks. |
carlosdauden
approved these changes
Dec 16, 2019
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 16, 2019
|
Congratulations, your PR was merged at fcb49b2. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
9.0-account_tax_balance-move_type_compute_optimized
branch
|
I think this improvement is as well valid for 10.0, 11.0, 12.0... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced complexity based on
read_group. This method was prefetching a lot and doing many slow operations.Executing in a real database for 197361 recs. took 14 minutes before and 1:36 minutes now.
@Tecnativa TT18838