7.0 mis builder backport from 8.0 #90

lmignon · 2015-06-15T16:01:06Z

Back port mis_builder from 8.0 (#86)

gurneyalex · 2015-07-24T06:40:18Z

My PR fixing the travis and runbot builds on the 8.0 branch were recently merged. Can you rebase your PR?

lmignon · 2015-07-24T06:49:59Z

@gurneyalex done.

gurneyalex · 2015-07-27T07:40:42Z

I let you backport the fixes asked on #86 when they get applied in there 😸

JordiBForgeFlow · 2015-10-06T22:43:18Z

I have applied the fixes asked on #86, in acsone#7. Please @lmignon review and merge if you agree.

sebalix · 2015-10-26T15:09:38Z

I implemented this module on a 7.0 instance for some statistics unrelated to accounting, it works like a charm (with SUM and AVG queries). 👍

sbidoul · 2015-11-02T18:20:06Z

rebased

pedrobaeza · 2015-11-02T18:24:16Z

Can you squash the commit history. 179 commit seems a lot of commits.

sbidoul · 2015-11-02T18:24:51Z

@pedrobaeza the commits are in the 8.0 branch. And there are several authors.

Not sure why travis is complaining. Anyway errors seem unrelated so 👍

Thanks @jbeficent for the last effort.

sbidoul · 2015-11-02T18:26:08Z

Can you squash the commit history. 179 commit seems a lot of commits.

It's a lot of work too 😉

pedrobaeza · 2015-11-02T18:27:51Z

All commits from different authors come together, so not too much, but I'm not going to force you.

JordiBForgeFlow · 2015-12-03T09:03:15Z

@sbidoul Not sure why Travis fails. It's not related to the changes made.

sebalix · 2015-12-03T11:58:51Z

mis_builder/models/mis_builder.py

+                elif query.aggregate == 'max':
+                    agg = max
+                elif query.aggregate == 'avg':
+                    agg = lambda l: sum(l) / float(len(l))


I encounter a problem here, a division by 0 could happen if there is no rows to compute.
I fixed it with the following line:

agg = lambda l: l and sum(l) / float(len(l)) or 0

@sebalix this was a backport issue. It should be fixed with @jbeficent's last commit: 30744ab

@sbidoul @jbeficent thanks

JordiBForgeFlow · 2015-12-03T13:01:10Z

Travis says:
mis_builder/openerp.py:25: [C8102(manifest-required-key), ] Missing required key "images" in manifest file

But in OCA maintainer-tools template: https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py I don't see this parameter being a requirement.

nmoturi · 2015-12-03T20:12:13Z

We been using MIS Builder V7 successfully and would be glad if its gets pushed to OCA asap.

Thanks,
Naran

…style reports Such reports combine accounting and operational data. This initial commit is a first proof-of-concept prototype.

…or posted). Add onchange and check function on report

…ooltip on the result (to display val_c). add from to. right align for column header and values. update preview form to have better display. define security

…w to compare column with any column of the table.

Conflicts: mis_builder/__openerp__.py cherry-pick from v8

Make it closer to the evaluation context available for server actions. Conflicts: mis_builder/models/mis_builder.py cherry-pick from v8

… code to v7

The dependency is indeed declared in __openerp__.py and will be enforced. Odoo evaluates all python files, even for modules which are not installed, and crashes if an unneeded dependency is needed. Conflicts: mis_builder/report/__init__.py cherry picked

The description has been generated using rst2html5. The path to the images has been manually fixed by removing 'static/description/' from the path. The body element has been replaced by a section wrapping the whole content.

Conflicts: mis_builder/README.rst cherry pick to v7

so min(x, y, ...) and min([x, y, ..]) both work as expected.

Conflicts: mis_builder/models/mis_builder.py cherry pick from v8

…b17def

…sualisation

sbidoul · 2015-12-03T20:40:00Z

I rebased. No idea why travis fails. Seems unrelated. IMO, this is good for merging.

lmignon · 2015-12-04T07:16:06Z

There are 2 pytlint errors

======== Testing test_pylint ========
************* Module account_chart_report.__openerp__
account_chart_report/__openerp__.py:28: [W1401(anomalous-backslash-in-string), ] Anomalous backslash in string: '\ '. String constant might be missing an r prefix.
account_chart_report/__openerp__.py:28: [W1401(anomalous-backslash-in-string), ] Anomalous backslash in string: '\ '. String constant might be missing an r prefix.

And travis need to fixed. The tests fails since the dependencies are no more checked out in the directory exepected by travis_run_tests. We must declare the dependencies in a oca_dependencies.txt file.

lmignon · 2015-12-04T07:39:39Z

Pep8 issue is fixed and travis runs but it seems that we have a regression. https://travis-ci.org/OCA/account-financial-reporting/jobs/94815699#L335

2015-12-04 07:35:47,188 22916 TEST openerp_test openerp.modules.module: FAIL: test_datetime_conversion (openerp.addons.mis_builder.tests.test_mis_builder.test_mis_builder)
2015-12-04 07:35:47,188 22916 TEST openerp_test openerp.modules.module: Traceback (most recent call last):
2015-12-04 07:35:47,188 22916 TEST openerp_test openerp.modules.module: `   File "/home/travis/build/OCA/account-financial-reporting/mis_builder/tests/test_mis_builder.py", line 40, in test_datetime_conversion
2015-12-04 07:35:47,188 22916 TEST openerp_test openerp.modules.module: `     'The converted date time convert must contains hour')
2015-12-04 07:35:47,188 22916 TEST openerp_test openerp.modules.module: ` AssertionError: '2014-07-04' != '2014-07-04 22:00:00'
2015-12-04 07:35:47,188 22916 TEST openerp_test openerp.modules.module: ` - 2014-07-04
2015-12-04 07:35:47,189 22916 TEST openerp_test openerp.modules.module: ` + 2014-07-04 22:00:00
2015-12-04 07:35:47,189 22916 TEST openerp_test openerp.modules.module: `  : The converted date time convert must contains hour
2015-12-04 07:35:47,189 22916 TEST openerp_test openerp.modules.module: `
2015-12-04 07:35:47,189 22916 TEST openerp_test openerp.modules.module: Ran 2 tests in 0.029s
2015-12-04 07:35:47,189 22916 TEST openerp_test openerp.modules.module: FAILED
2015-12-04 07:35:47,189 22916 TEST openerp_test openerp.modules.module:  (failures=1)

lmignon · 2015-12-04T08:08:41Z

@sbidoul Travis is green. It's ready to be merged

JordiBForgeFlow · 2015-12-04T08:28:59Z

Thanks @lmignon and @sbidoul! 👍

sbidoul · 2015-12-09T10:04:25Z

I'm merging now. Many thanks to all who contributed to this backport.

7.0 mis builder backport from 8.0

[8.0] account_default_draft_move uses tuples instead of lists in sql operations

lmignon force-pushed the 7.0-mis_builder-lmi-2 branch from 5547c0f to b666d1f Compare July 24, 2015 06:49

lmignon force-pushed the 7.0-mis_builder-lmi-2 branch from b666d1f to c6a732b Compare July 24, 2015 06:56

sbidoul force-pushed the 7.0-mis_builder-lmi-2 branch from 275a8e6 to e717d5c Compare November 2, 2015 18:19

sebalix reviewed Dec 3, 2015
View reviewed changes

JordiBForgeFlow mentioned this pull request Dec 3, 2015

[FIX] avoid division by 0 acsone/account-financial-reporting#9

Merged

sbidoul and others added 12 commits December 3, 2015 21:30

[ADD] mis_builder: a module to build "Management Information System"-…

c4a557f

…style reports Such reports combine accounting and operational data. This initial commit is a first proof-of-concept prototype.

Add the possibility to set the result of report instance in a dashboard

9e64b91

Add demo data. Set computed result. In instance add target_move (all …

9befa37

…or posted). Add onchange and check function on report

add datetime support, normalize query name and balance account name

c587395

add little test for datetime support

d1bfc55

Add mechanism to add comparison column

0b9c532

use openerp style to display result

2d6887e

correct instance to have unique period

cc430fa

add company_id in period. in queries add the usable field name. add t…

ab5e88a

…ooltip on the result (to display val_c). add from to. right align for column header and values. update preview form to have better display. define security

review of the computed table to get a more readable dict result. Allo…

1791b51

…w to compare column with any column of the table.

add a css style expression on kpi

58e07b1

compute average in comparison column

89ad437

lmignon and others added 15 commits December 3, 2015 21:30

[FIX] Add OCA as author

116c501

Conflicts: mis_builder/__openerp__.py cherry-pick from v8

[IMP] Add module description

0de1339

[IMP] mis_builder: improve eval context of query domain

9ba019c

Make it closer to the evaluation context available for server actions. Conflicts: mis_builder/models/mis_builder.py cherry-pick from v8

[IMP] cherry pick commits in V8 from a809796 to 09d69b9 and adapt the…

2a0df08

… code to v7

import guard for report_xls

17560f6

The dependency is indeed declared in __openerp__.py and will be enforced. Odoo evaluates all python files, even for modules which are not installed, and crashes if an unneeded dependency is needed. Conflicts: mis_builder/report/__init__.py cherry picked

Add static description to get a proper look on app store

9d26832

The description has been generated using rst2html5. The path to the images has been manually fixed by removing 'static/description/' from the path. The body element has been replaced by a section wrapping the whole content.

[FIX] Heading levels

9f28fe6

Conflicts: mis_builder/README.rst cherry pick to v7

[IMP] mis_builder: update min/max function signatures

1ee7dc0

so min(x, y, ...) and min([x, y, ..]) both work as expected.

[FIX] mis_builder: correct implementation and doctests for _min/_max

5420d7a

Conflicts: mis_builder/models/mis_builder.py cherry pick from v8

[IMP] cherry-pick commits from v8 and adapt.

2105849

[IMP] manual cherry picking of v8 commits 4f60e4c af05e07 f4fbab3 and c…

50ed925

…b17def

[FIX] fix flake8 and pylint errors

4260b11

mis_builder backport: squash last pep8 errors

12557f3

[FIX] remove field 'landscape_pdf' and reorganize views for better vi…

29ea048

…sualisation

[FIX] avoid division by 0

e6ecd5b

sbidoul force-pushed the 7.0-mis_builder-lmi-2 branch from 30744ab to e6ecd5b Compare December 3, 2015 20:32

lmignon added 2 commits December 4, 2015 08:25

Upgrades travis.yml to latest OCA standard

6e96478

PEP8 Make the docstring a raw string to avoid Pylint W1401

35c47a2

Fixes date convert to _utc_midnight

1cdf38d

lmignon force-pushed the 7.0-mis_builder-lmi-2 branch from bac9872 to 1cdf38d Compare December 4, 2015 08:01

sbidoul added a commit that referenced this pull request Dec 9, 2015

Merge pull request #90 from acsone/7.0-mis_builder-lmi-2

d7b417a

7.0 mis builder backport from 8.0

sbidoul merged commit d7b417a into OCA:7.0 Dec 9, 2015

sbidoul deleted the 7.0-mis_builder-lmi-2 branch December 9, 2015 10:04

rconjour pushed a commit to EssentNovaTeam/account-financial-reporting that referenced this pull request Mar 16, 2020

Merge pull request OCA#90 from sbidoul/patch-1

208b00c

[8.0] account_default_draft_move uses tuples instead of lists in sql operations

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7.0 mis builder backport from 8.0 #90

7.0 mis builder backport from 8.0 #90

lmignon commented Jun 15, 2015

gurneyalex commented Jul 24, 2015

lmignon commented Jul 24, 2015

gurneyalex commented Jul 27, 2015

JordiBForgeFlow commented Oct 6, 2015

sebalix commented Oct 26, 2015

sbidoul commented Nov 2, 2015

pedrobaeza commented Nov 2, 2015

sbidoul commented Nov 2, 2015

sbidoul commented Nov 2, 2015

pedrobaeza commented Nov 2, 2015

JordiBForgeFlow commented Dec 3, 2015

sebalix Dec 3, 2015

sbidoul Dec 3, 2015

sebalix Dec 4, 2015

JordiBForgeFlow commented Dec 3, 2015

nmoturi commented Dec 3, 2015

sbidoul commented Dec 3, 2015

lmignon commented Dec 4, 2015

lmignon commented Dec 4, 2015

lmignon commented Dec 4, 2015

JordiBForgeFlow commented Dec 4, 2015

sbidoul commented Dec 9, 2015

7.0 mis builder backport from 8.0 #90

7.0 mis builder backport from 8.0 #90

Conversation

lmignon commented Jun 15, 2015

gurneyalex commented Jul 24, 2015

lmignon commented Jul 24, 2015

gurneyalex commented Jul 27, 2015

JordiBForgeFlow commented Oct 6, 2015

sebalix commented Oct 26, 2015

sbidoul commented Nov 2, 2015

pedrobaeza commented Nov 2, 2015

sbidoul commented Nov 2, 2015

sbidoul commented Nov 2, 2015

pedrobaeza commented Nov 2, 2015

JordiBForgeFlow commented Dec 3, 2015

sebalix Dec 3, 2015

Choose a reason for hiding this comment

sbidoul Dec 3, 2015

Choose a reason for hiding this comment

sebalix Dec 4, 2015

Choose a reason for hiding this comment

JordiBForgeFlow commented Dec 3, 2015

nmoturi commented Dec 3, 2015

sbidoul commented Dec 3, 2015

lmignon commented Dec 4, 2015

lmignon commented Dec 4, 2015

lmignon commented Dec 4, 2015

JordiBForgeFlow commented Dec 4, 2015

sbidoul commented Dec 9, 2015