[14.0][MIG] account_check_deposit #1088

alexis-via · 2020-11-13T23:35:15Z

For the moment, still in beta. I still have to clarify a few things on:

the new datamodel of account.journal (the new M2O fields on account.account)
cancellation of move
Tests have not been ported yet.

But I tested the module and it works well.

Saran440 · 2020-11-16T15:02:39Z

@alexis-via
Hi, this module is migrated on PR #1082
Could you review this PR?

kittiu · 2020-12-24T08:15:29Z

@alexis-via can we close this as it is duplicated? Or anything you want to add to #1082 ?

alexis-via · 2020-12-24T08:28:30Z

No, this PR should not be closed. It contains several improvements that are not present in your PR. We'd better merge the best PR.

kittiu · 2020-12-24T17:50:44Z

@Saran440 you can help review this? I agree we go with the best one.

kittiu · 2021-01-23T02:52:08Z

Test failing.

    from . import test_check_deposit
  File "/home/travis/build/OCA/account-financial-tools/setup/account_check_deposit/odoo/addons/account_check_deposit/tests/test_check_deposit.py", line 7, in <module>
    from odoo.addons.account.tests.account_test_classes import AccountingTestCase
ModuleNotFoundError: No module named 'odoo.addons.account.tests.account_test_classes'

* Clean code * Add access rules for account_check_deposit * Change print button name

* [FIX] fix datamodel structure, indeed check_payment_ids should be a m2o. In the view we still keep the widget * [REF] remove useless state cancel, only draft/done is sufficent for now, forbid to delete a done deposit, fix move_line name need to be the equal to the line.ref for the reconciliation * [IMP] improve reconciliation between the check and the check deposit * [FIX] set correctly the date on the move line generated * [FIX] fix reconciliation of check * [IMP] check deposit improve view and add tab for move line generated * [IMP] add total amount and flag to know if the deposit have been reconcile, the best will be to add a workflow * [FIX] fix error when replaying commit * [REF] remove dependency on sale_quick_payment as check can be registred in various way like native voucher * [CLEAN] pep8 cleanup no code change * [REF] clean remove useless code, default value are called during the create * [FIX] fix wrong spelling * [REF] V7 clean up

Works with a single account journal Usability and many other enhancements

… for the payment, one for the deposit), hide unreconcile entry which a link to a deposit

Convert webkit report to qweb

* Move description from __openerp__.py to README.rst * Move files in sub-directories * FIX access rights issue when user was not accounting manager

* create move and move line at the same time * add tests

* Add option to have the counter-part of the deposit move directly to the bank account Use account.config.settings page * Remove data that create a bank journal because it blocks the loading of the chart of accounts when the module is installed at the same time as the chart of account (via dependencies)

…rnal if the offsetting account is the bank account

For avoiding constraint.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_check_deposit/

…es, so we should always post the move

alexis-via · 2021-04-22T08:17:17Z

FYI, I plan to do the following change : remove the fields "check_deposit_offsetting_account" and "check_deposit_transfer_account_id" on res.company. The transfer account will be the bank account of the check journal. Please refer to my recent post in OCA/bank-payment#740 to understand the reasons of this change.

alexis-via · 2021-04-22T08:26:22Z

I have a better idea: the transfer account will be the outstanding receipts account of the bank journal on which you do the check deposit. That way, if you have an outstanding receipts account different for each bank journal, the amounts for confirmed check deposits will be in an account which is specific to the bank on which you made the deposit. The bank account of the check journal will not be used (the suspense account of the check journal will not be used either).

Update documentation Don't duplicate labels between name of account.move.line and ref of account.move, now that name of account.move.line is not required any more.

alexis-via · 2021-04-22T09:00:59Z

I implemented what I described in my previous comment.

Add button "Get All Received Checks" Add default value for journal_id and bank_journal_id when there is only 1 possible value Add hide/show options on lines Improve multi-company handling

alexis-via · 2021-04-22T11:03:27Z

If nobody is against it, I think I'll add a chatter on account.check.deposit.

Add chatter message when you click on the button to get all checks Add unicity SQL constraint

alexis-via · 2021-04-22T17:52:21Z

I don't plan to make other changes. Ready to merge.

newtratip · 2021-05-15T08:28:36Z

@Saran440, @kittiu Could you review/approve this PR ? I will change PR Url in our project from #1082 to #1088 if it's OK.

kittiu

Good for me.

kittiu · 2021-06-05T16:06:31Z

/ocabot merge nobump

OCA-git-bot · 2021-06-05T16:06:45Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1088-by-kittiu-bump-nobump, awaiting test results.

OCA-git-bot · 2021-06-05T16:27:30Z

Congratulations, your PR was merged at 413f65c. Thanks a lot for contributing to OCA. ❤️

alexis-via · 2021-06-06T21:57:51Z

Thanks @kittiu for the review and merge !

alexis-via force-pushed the 14-mig-check_deposit branch from 441adc2 to 526c8ab Compare December 24, 2020 08:58

bguillot and others added 24 commits April 21, 2021 13:39

[INIT] init module to manage check deposits

abe96ad

[FIX] fix remove pdb call

830fac1

[IMP]account_check_deposit: add the print option webkit

5705bab

[FIX+IMP] account_check_deposit: Several things:

1127750

* Clean code * Add access rules for account_check_deposit * Change print button name

Add support for multi-currency

40ba098

Works with a single account journal Usability and many other enhancements

[FIX] fix domain, give the posibility to use a different journal (one…

5ae4bf9

… for the payment, one for the deposit), hide unreconcile entry which a link to a deposit

german translations upto invoice currency

01d540d

[FIX] move translation file in unported folders

9cf2090

[PORT] start porting account_check_deposit

4d8e32c

Port to v8

2723e7b

Convert webkit report to qweb

OCA Transbot updated translations from Transifex

f4f958a

[REF] account_check_deposit : Port to new API

09dce60

* Move description from __openerp__.py to README.rst * Move files in sub-directories * FIX access rights issue when user was not accounting manager

OCA Transbot updated translations from Transifex

6239671

[MIG] account_check_deposit: Migration to 9.0

2d909bb

* create move and move line at the same time * add tests

Fix payment field + automatic reconciliation on validation

026c07b

OCA Transbot updated translations from Transifex

68d68cc

[FIX+imp] account_check_deposit: no auto-post move + use the bank jou…

b2f5576

…rnal if the offsetting account is the bank account

OCA Transbot updated translations from Transifex

d8e90f0

[FIX] account_check_deposit: Change company currency in tests by SQL

b78e075

For avoiding constraint.

[UPD] Update account_check_deposit.pot

37226b9

[MIG] account_check_deposit: Migration to 11.0

df84eb0

[UPD] Update account_check_deposit.pot

eb793f8

oca-travis and others added 5 commits April 21, 2021 13:39

[UPD] Update account_check_deposit.pot

5244bc5

[MIG] account_check_deposit from v13 to v14

7a858da

Remove post_move option, because we cannot reconcile non-posted entri…

f191edb

…es, so we should always post the move

alexis-via force-pushed the 14-mig-check_deposit branch from 5bcc39e to f191edb Compare April 21, 2021 11:39

alexis-via mentioned this pull request Apr 22, 2021

Migration to version 14.0 OCA/bank-payment#740

Closed

11 tasks

account_check_deposit: remove configuration parameters from res.company

1b0c4a4

Update documentation Don't duplicate labels between name of account.move.line and ref of account.move, now that name of account.move.line is not required any more.

account_check_deposit: usability improvements

9699aa3

Add button "Get All Received Checks" Add default value for journal_id and bank_journal_id when there is only 1 possible value Add hide/show options on lines Improve multi-company handling

alexis-via force-pushed the 14-mig-check_deposit branch from b786b19 to 9699aa3 Compare April 22, 2021 10:32

account_check_deposit: migrate tests

7f8d980

account_check_deposit: Add chatter on check deposit

af333cf

Add chatter message when you click on the button to get all checks Add unicity SQL constraint

kittiu mentioned this pull request Apr 26, 2021

[14.0][MIG] account_check_deposit #1082

Closed

kittiu approved these changes Jun 3, 2021

View reviewed changes

Saran440 approved these changes Jun 5, 2021

View reviewed changes

OCA-git-bot added the approved label Jun 5, 2021

OCA-git-bot added the bot is merging ⏳ label Jun 5, 2021

OCA-git-bot merged commit ce4e04d into OCA:14.0 Jun 5, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] account_check_deposit #1088

[14.0][MIG] account_check_deposit #1088

alexis-via commented Nov 13, 2020

Saran440 commented Nov 16, 2020

kittiu commented Dec 24, 2020

alexis-via commented Dec 24, 2020

kittiu commented Dec 24, 2020

kittiu commented Jan 23, 2021

alexis-via commented Apr 22, 2021

alexis-via commented Apr 22, 2021 •

edited

Loading

alexis-via commented Apr 22, 2021

alexis-via commented Apr 22, 2021

alexis-via commented Apr 22, 2021

newtratip commented May 15, 2021

kittiu left a comment

kittiu commented Jun 5, 2021

OCA-git-bot commented Jun 5, 2021

OCA-git-bot commented Jun 5, 2021

alexis-via commented Jun 6, 2021

[14.0][MIG] account_check_deposit #1088

[14.0][MIG] account_check_deposit #1088

Conversation

alexis-via commented Nov 13, 2020

Saran440 commented Nov 16, 2020

kittiu commented Dec 24, 2020

alexis-via commented Dec 24, 2020

kittiu commented Dec 24, 2020

kittiu commented Jan 23, 2021

alexis-via commented Apr 22, 2021

alexis-via commented Apr 22, 2021 • edited Loading

alexis-via commented Apr 22, 2021

alexis-via commented Apr 22, 2021

alexis-via commented Apr 22, 2021

newtratip commented May 15, 2021

kittiu left a comment

Choose a reason for hiding this comment

kittiu commented Jun 5, 2021

OCA-git-bot commented Jun 5, 2021

OCA-git-bot commented Jun 5, 2021

alexis-via commented Jun 6, 2021

alexis-via commented Apr 22, 2021 •

edited

Loading