Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD]product_category_tax #1091

Merged
merged 2 commits into from Jan 21, 2021

Conversation

AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Nov 17, 2020

Allows to define taxes in the product category.

@ForgeFlow

PS: Do not merge yet, pending to solve this: #1091 (comment)

* add a boleean to exclude specific products to be updated
@AaronHForgeFlow
Copy link
Contributor Author

ping @LoisRForgeFlow I think this is ready :)

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@LoisRForgeFlow
Copy link
Contributor

Just a warning for merge masters, I know this is approved by 2 people but, please, hold on this until I am able to validate it, I want to check if the requirement from our customer is fully covered.

Thanks!

"product.template", "categ_id", string="Products Templates"
)

def update_product_taxes(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be called on write, doesn't it? requiring a click is not very user friendly.

@LoisRForgeFlow
Copy link
Contributor

Hi, this is good to merge now.

thanks!

@dreispt
Copy link
Sponsor Member

dreispt commented Jan 21, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-1091-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 21, 2021
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-1091-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 67801cd into OCA:13.0 Jan 21, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5efca3c. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 13.0-product_category_tax branch January 21, 2021 13:37
@@ -0,0 +1,13 @@
# Copyright 2020 ForgeFlow S.L. (https://www.forgeflow.com)
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
Copy link
Sponsor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronHForgeFlow @JordiBForgeFlow I will migrate this. Is the license AGPL or LGPL as they are mixed through the module ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think AGPL is fine, as long as no other modules are built on top of this one.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants