New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][ADD]product_category_tax #1091
Conversation
* add a boleean to exclude specific products to be updated
ping @LoisRForgeFlow I think this is ready :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review 👍
Just a warning for merge masters, I know this is approved by 2 people but, please, hold on this until I am able to validate it, I want to check if the requirement from our customer is fully covered. Thanks! |
"product.template", "categ_id", string="Products Templates" | ||
) | ||
|
||
def update_product_taxes(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be called on write, doesn't it? requiring a click is not very user friendly.
Hi, this is good to merge now. thanks! |
/ocabot merge nobump |
On my way to merge this fine PR! |
It looks like something changed on |
Congratulations, your PR was merged at 5efca3c. Thanks a lot for contributing to OCA. ❤️ |
@@ -0,0 +1,13 @@ | |||
# Copyright 2020 ForgeFlow S.L. (https://www.forgeflow.com) | |||
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronHForgeFlow @JordiBForgeFlow I will migrate this. Is the license AGPL or LGPL as they are mixed through the module ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think AGPL is fine, as long as no other modules are built on top of this one.
Thank you.
Allows to define taxes in the product category.
@ForgeFlow
PS: Do not merge yet, pending to solve this: #1091 (comment)