Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bugfixes on taxes compares and updates #231

Merged
merged 4 commits into from
Jun 24, 2015

Conversation

antespi
Copy link
Contributor

@antespi antespi commented Jun 5, 2015

[FIX] Set updated taxes as active
[FIX] Check parent_id field in '_is_different_tax' method
[FIX] PEP8

[FIX] Check parent_id field in '_is_different_tax' method
[FIX] PEP8
"""Check the tax for changes.
:return: An string that will be empty if no change detected.
"""
notes = ""
if tax.active == False:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better if not tax.active:

@antespi
Copy link
Contributor Author

antespi commented Jun 8, 2015

I've also update .pot file, no updated since v5. But I can only update Spanish translation.

@pedrobaeza
Copy link
Member

👍

@Endika
Copy link

Endika commented Jun 24, 2015

👍

@pedrobaeza
Copy link
Member

Runbot warning unrelated, so I merge

pedrobaeza added a commit that referenced this pull request Jun 24, 2015
Several bugfixes on taxes compares and updates
@pedrobaeza pedrobaeza merged commit 0b51096 into OCA:8.0 Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants