Adding account move select reconciliation 7

[eLBati]

This module allows to manually select the journal item to be reconciled while
registering a journal entry.

Example (also see the included test case)

You have an open credit and you need to close it by a manual journal entry.
With this module you can manually create the payment journal entry, select the
open credit and click 'Reconcile Line'. The system will close the credit
generating the respective reconciliation.

[tafaRU]

I think here has been used a tab as indentation instead spaces

[tafaRU]

See eLBati#1

[eLBati]

Thanks @tafaRU

[coveralls]

Coverage increased (+1.23%) when pulling e1eb829 on eLBati:adding_account_move_select_reconciliation_7 into a0220d8 on OCA:7.0.

[sbidoul]

I did a quick test of this module and it works well.

That said, I'm always a bit worried when I see modules adding columns to account.move.line. And in this case the new column is there only to satisfy a pure UI/ergonomy requirement. Would it not be better to have a wizard on the move form to select the line to reconcile and add it to the move (plus the red button to unreconcile)? What do you think?

On a related note, is it correct that the same effect can be achieved by selecting one move line (in the Journal Items view) and doing a reconcile with writeoff?

[eLBati]

Hello @sbidoul , what problem do you see in adding a column to account.move.line?

About related note: the same effect can be achieved by the 'reconcile entries' wizard. This module allows to reconcile at the same time of registering a journal entry

[sbidoul]

Hello @eLBati, I can't really say the additional column will create hard issues. It's just making me uneasy to add a column that will use space (and time in foreign key checks), where this column is only used at data entry time.

[joaoalf]

IMHO is not really interesting to set a domain directly in the model, especially in this case where you're passing an string as domain (it will be evaluated on the client side). If you're setting a client side domain, I think it's better to set it on the xml form.

[StefanRijnhart]

LGTM 👍. I'm not too worried about nags expressed by the previous reviewers, i.e. the extra column in the move line table, nor the text domain on the column itself.

[sbidoul]

By changing this to //field[@name='line_id']/tree/field[@name='name'] the module works on 8.0 too.

[sbidoul]

Hi @eLBati, @tafaRU,

I finally had a chance to test this module (on 8.0). It works great!

Have you considered reconciling several moves of the same account at once? With move_line_to_reconcile_id would becoming a many2many instead of a many2one, the module would easily cover additional use cases (such as closing several open moves at once with a complex operation).

[max3903]

👍