[10.0] Restore account hierarchy and views #505

hongquangminh · 2017-06-17T05:26:04Z

Restore account hierarchy and views

oca-clabot · 2017-06-17T05:26:06Z

Hey @minhhq09, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@minhhq09 (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

jcdrubay · 2017-06-18T03:45:40Z

account_parent/README.rst

+Configuration
+=============
+
+Need to set the group show chart of account structure to view the chart of account heirarchy.


heirarchy should be hierarchy

jcdrubay · 2017-06-18T03:53:22Z

account_parent/security/account_parent_security.xml

+        <field name="implied_ids" eval="[(4, ref('account.group_account_manager'))]"/>
+        <field name="users" eval="[(4, ref('base.user_root'))]"/>
+    </record>
+</odoo>


You should change the logo of the module.

Maybe this one: https://upload.wikimedia.org/wikipedia/commons/9/9c/Categorisation-hierarchy-top2down.svg

oca-clabot · 2017-06-20T02:06:26Z

Hey @minhhq09,
We acknowledge that the following users have signed our Contributor License Agreement:

@minhhq09

Appreciation of efforts,
OCA CLAbot

jcdrubay · 2017-06-20T02:51:11Z

account_parent/models/account.py

+
+    @api.model
+    def _move_domain_get(self):
+        context = dict(self._context or {})


I think this function should return 2 values:

domain

params

Then you can build safely the SQL query avoiding SQL injection.

Thanks for your comment :)

I did rewrite the query to avoiding SQL injection in compute function.
The function compute for each account. So we just need get domain in here

You should separate code and parameters.

Resources:

Rule [IMP] modify menu item for item search extension #3 here: https://www.odoo.com/fr_FR/slides/slide/10-rules-for-safer-code-398?&

https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#no-sql-injection

jcdrubay · 2017-06-20T02:52:50Z

account_parent/models/account.py

+                {'show_parent_account': True}).search([
+                    ('id', 'child_of', [account.id])])
+            params = [tuple(sub_accounts.ids)]
+            self.env.cr.execute(query, params)


I believe that we could execute the query only once and outside the for loop using a group by l.account_id in the query. This should help with performance.

Like i say above. Compute value just for each account. In Vietnamese, the parent account can sum debit/credit value of childrent account. Example: I want report debit, credit, balance off account: 111 - Cash. The function will return sum debit, credit of childrent account is: 1111, 1112, 1113

When you open the Chart of Account Hierarchy, you display several accounts and for each balance, sum debit and sum credit at the same time.

You should execute the SQL query only once for all accounts.

That's funtion fields will be automated compute value. I think it don't the same when you click on button and compute value of all account.

The wizard no call to that function. It just show hierarchy view with already exist data. When you find any account you also can see debit, credit, balance.

I am 99% sure that if you add self.ensure_one() as the first line of def _compute_values you won't be able to open the hierarchical view of accounts.

I think that the function _compute_values will be called with self that will be a recordset of multiple accounts.

Okay, i will try fix it one more time.

Thank JC,

jcdrubay · 2017-06-20T05:28:01Z

account_parent/tests/test_account_open_chart.py

+            'company_id': self.company_id
+        })
+
+        # Test that the open chart cannot open window


From:

# Test that the open chart cannot open window

To

# Test that the function account_chart_open_window can be executed # without arguments/special context

jcdrubay · 2017-06-20T06:15:00Z

account_parent/README.rst

+==============
+
+This module will be very useful for those who are still using v7/v8 
+because of the no parent account and chart of account heirarchy view in the latest versions


5 iterations of heirarchy instead of hierarchy in the code of this PR

jcdrubay · 2017-06-20T06:19:53Z

account_parent/models/account.py

+
+    @api.model
+    def _move_domain_get(self):
+        context = dict(self._context or {})


You should separate code and parameters.

Resources:

Rule [IMP] modify menu item for item search extension #3 here: https://www.odoo.com/fr_FR/slides/slide/10-rules-for-safer-code-398?&

https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#no-sql-injection

…ccounts

hbto · 2017-07-03T11:10:51Z

account_parent/models/account.py

+    parent_id = fields.Many2one(
+        'account.account', 'Parent Account', ondelete='restrict')
+    child_ids = fields.One2many(
+        'account.account', 'parent_id', 'Child Accounts')


Hi everyone,

Why don't we just implement the Hierarchy implemented in Odoo/master
that just landed a few days ago at commit odoo/odoo@5967600

This new approach, I think could fit to everyone allowing to provide Hierarchy,
Using the current way can lead to huge overheads to compute the recursive
values of the parent-children accounts, I am aware that we need the Hierarchy
but this new approach leaves the computation of the parent-child values to
reporting and the parent-children relationship is separated into two, that hierarchy
is only left to parents which bear no moves (account.group) and the account.account
is the ultimate children that bears only moves.

As @fpodoo explained at odoo/odoo#17367 (comment)

This is more elegant and less power/resource consuming.

This computed fields will lead to the overhead that once crippled the previous odoo versions.

Best Regards

congdpt · 2017-08-04T09:40:26Z

account_parent/models/account.py

+    @api.model
+    def search(self, args, offset=0, limit=None, order=None, count=False):
+        context = self._context or {}
+        if not context.get('show_parent_account', False):


I think it's make better if we check show_parent_account is True. May be, we will change many code.
Because another line in all module don't has set this context before. If we check fail, all line will go into condition
if not context.get('show_parent_account', False): > if context.get('show_parent_account'):

jcdrubay · 2017-11-26T07:22:41Z

So with version 11 it seems that:

Odoo has not been using the concept of account.group anywhere in the code (neither community nor enterprise)
Odoo has removed the hierarchical view (tree view with a field_parent as we used here) from community.

I wonder what is the best way to have a hierarchy of accounts with balance in version 11 ... :/

pedrobaeza · 2017-11-26T12:34:57Z

@jcdrubay, @rlizana has been working in the Madrid code sprint in a tree view using account.group. There's a problem with that view with new JS architecture that should be reported, but the rest is almost done.

feketemihai · 2018-02-14T07:02:47Z

@pedrobaeza @rlizana Can you put a link from that work, i'm interested too.

jholze · 2018-02-28T11:12:56Z

Guys, is there something done already for this topic. We are also searching for an addon to get this backed hierarchy back into odoo.

jcdrubay · 2018-04-19T08:09:23Z

@pedrobaeza @rlizana @congdpt any news would be welcome :)

first create account_parent

01f9d79

hongquangminh added 4 commits June 17, 2017 12:41

update

ee4772e

update again

38e3745

edit readme file and some file with pylint

ae7c9b6

fix aggrs []

2cc82c6

jcdrubay suggested changes Jun 18, 2017

View reviewed changes

hongquangminh added 2 commits June 18, 2017 10:58

fix with flake8

67ce572

fix with flake8

b1afa19

hongquangminh changed the title ~~first create account_parent~~ Restore account hierarchy and views Jun 19, 2017

hongquangminh mentioned this pull request Jun 19, 2017

Error with test module account_journal_lock_date #506

Closed

fix error security

5de534d

jcdrubay suggested changes Jun 20, 2017

View reviewed changes

add test

a7d8f65

jcdrubay suggested changes Jun 20, 2017

View reviewed changes

update usage & re comment in test file

23d0db1

jcdrubay suggested changes Jun 20, 2017

View reviewed changes

hongquangminh added 2 commits June 20, 2017 13:51

change from Heirarchy > Hierarchy, separate code and parameters

bab888a

update readme

1db94b0

hongquangminh changed the title ~~Restore account hierarchy and views~~ [10.0] Restore account hierarchy and views Jun 20, 2017

hongquangminh added 2 commits June 21, 2017 09:40

fix with function _compute_values called by a recordset of multiple a…

3e7200a

…ccounts

update readme

23c498e

hbto reviewed Jul 3, 2017

View reviewed changes

congdpt suggested changes Aug 4, 2017

View reviewed changes

fanha99 mentioned this pull request Sep 8, 2017

Step 1: general modification OCA/l10n-vietnam#5

Closed

11 tasks

gurneyalex added this to the 10.0 milestone Oct 16, 2017

hongquangminh closed this Oct 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0] Restore account hierarchy and views #505

[10.0] Restore account hierarchy and views #505

hongquangminh commented Jun 17, 2017 •

edited

oca-clabot commented Jun 17, 2017

jcdrubay Jun 18, 2017

jcdrubay Jun 18, 2017

oca-clabot commented Jun 20, 2017

jcdrubay Jun 20, 2017

hongquangminh Jun 20, 2017 •

edited

jcdrubay Jun 20, 2017

jcdrubay Jun 20, 2017

hongquangminh Jun 20, 2017

jcdrubay Jun 20, 2017

hongquangminh Jun 20, 2017

jcdrubay Jun 20, 2017

hongquangminh Jun 21, 2017

jcdrubay Jun 20, 2017

hongquangminh Jun 20, 2017

jcdrubay Jun 20, 2017

jcdrubay Jun 20, 2017

hbto Jul 3, 2017

levkar Jul 14, 2017

fanha99 Sep 1, 2017

congdpt Aug 4, 2017

jcdrubay commented Nov 26, 2017

pedrobaeza commented Nov 26, 2017

feketemihai commented Feb 14, 2018 •

edited

jholze commented Feb 28, 2018

jcdrubay commented Apr 19, 2018

[10.0] Restore account hierarchy and views #505

[10.0] Restore account hierarchy and views #505

Conversation

hongquangminh commented Jun 17, 2017 • edited

oca-clabot commented Jun 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oca-clabot commented Jun 20, 2017

Choose a reason for hiding this comment

hongquangminh Jun 20, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jcdrubay commented Nov 26, 2017

pedrobaeza commented Nov 26, 2017

feketemihai commented Feb 14, 2018 • edited

jholze commented Feb 28, 2018

jcdrubay commented Apr 19, 2018

hongquangminh commented Jun 17, 2017 •

edited

hongquangminh Jun 20, 2017 •

edited

feketemihai commented Feb 14, 2018 •

edited