[MIG] account_move_batch_validate: Migration to 9.0 #602
Conversation
|
Please check Travis. There's no extra commits to rescue from 8.0? Check migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 |
| 'author': "Camptocamp,Odoo Community Association (OCA)", | ||
| 'category': 'Finance', | ||
| 'complexity': 'normal', | ||
| 'depends': [ | ||
| 'account', | ||
| 'account_default_draft_move', | ||
| 'account_accountant', | ||
| 'connector', | ||
| ], | ||
| 'website': 'http://www.camptocamp.com', |
There was a problem hiding this comment.
|
|
||
|
|
||
| class AccountMove(models.Model): | ||
|
|
| return job | ||
|
|
||
| def test_batch_validate(self): | ||
|
|
|
@OleksandrPaziuk pls, check Pedro's comment about history. |
|
There are only 5 |
|
Yes, we need them because they are translations, but you have to squash them together. What we don't want is that detailed history. Please follow https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 and https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests guides |
| def validate_one_move(session, model_name, move_id): | ||
| """Validate a move, and leave the job reference in place.""" | ||
| move_ids = session.env[model_name].browse([move_id]) | ||
| if move_ids.exists(): |
There was a problem hiding this comment.
Code could be a bit simpler IMO: here we could check if to_post is still True, if not just leave with returning a message saying the move is not to post anymore. Thus we can remove the unmark_for_posting and _cancel_jobs methods. Anyway, this is a migration so maybe this PR is not the right place to change.
|
@guewen Unfortunately, someone incorrectly moves the module from 8 to 9 (before me) and therefore commits did not remain in history. Just in case, check if you want. |
Set missing priority
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
No description provided.