Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][add] account_move_budget, mis_builder_account_move_budget #789

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

JordiBForgeFlow
Copy link
Sponsor Member

Account Move Budget

This module allows to define accounting budgets.

These budgets can then be used in MIS Builder reports, as an alternate
source.

The difference between the MIS Builder Budget and this module is that
this module defines budgets irrespective of the MIS Builder Template. The
budget is thus agnostic of the reporting format.

For example, the budgeted data can be used in a general Profit & Loss report
and at the same time can be used in a department or project expenses report.

image

image

MIS Builder Account Move Budget

This module allows you to define, when you prepare a MIS Report,
the specific Account Move Budget that you want to use as an alternate
source.

image

image

@JordiBForgeFlow
Copy link
Sponsor Member Author

cc @sbidoul this module is similar to the mis_builder_budget, but allows you to define accounting budgets that are agnostic of the actual mis report template.

@sbidoul
Copy link
Member

sbidoul commented Mar 25, 2019

@jbeficent Is it not tedious to budget at the level of individual accounts?

If we implement OCA/mis-builder#155 (your idea in Sevilla last year, btw :), this should help for budgeting too.

You could have some kind of low-level mis.report providing the KPI's for the budget positions.
Then create higher level reports on top of it.

@JordiBForgeFlow
Copy link
Sponsor Member Author

@sbidoul thanks. I will think about this approach.

IMHO it is normal that one wants to budget at the same level where the actual transactions occurs.

For example, some companies want to compare a P&L or Trial Balance in actual vs Budget.https://help.sap.com/doc/saphelp_sbo900/9.0/en-US/45/10c7d90b9941dfe10000000a1553f6/frameset.htm

So this scenario covers an usual use case.

@fclementic2c
Copy link
Member

I understand you point guys. I wonder the same.
Truth is probably that sometimes you want to create a budget at account level and sometimes at budget item levels so we need both.
And we definitely need to decorrelate budget to templates

@jbeficent but how can you handle subkpis with such a view ?
The use case I have in mind is the following:
*I use subkpis as department.
*my main report template is a P&L with department in columns
*so I want create a budget by account AND departement.

@JordiBForgeFlow
Copy link
Sponsor Member Author

@fclementic2c how do you represent a department in an account move line?

The account.move.budget.line has almost the same fields as an account.move.line.

So your P&L report that works for move lines must work as well when the alternate source is the account.move.budget.line. thr same formulas in the kpi will apply.

So it's an elegant solution to me.

Also @sbidoul, the budget is very often constructed on a bottom-up approach. So a budget is the composition of the requests from various departments in a company.

@sbidoul
Copy link
Member

sbidoul commented Mar 26, 2019

@jbeficent to be clear, I'm totally fine with this PR. Just thinking out loud about the use case, as in my experience the chart of account is often too fine grained for budgeting purposes. I guess both apporaches are useful depending on the complexity of the CoA.

About departments, and bottom up construction, yes of course. The department is somehow a field on move lines, as well as budget lines, so you can report and budget on it.

@fclementic2c about subkpis, mis_builder_budget allows you to budget on subkpis (you know that I guess). As mentioned in OCA/mis-builder#168, I'm still not sure about the benefits of using subkpis for that though, compared to move line filters like in mis_builder_(budget_)operating_unit.

@sbidoul
Copy link
Member

sbidoul commented Mar 26, 2019

compared to move line filters like in mis_builder_(budget_)operating_unit

or the built-in analytic account filter which works out of the box if you can use the analytic account field.

OCA/mis-builder#138 and OCA/mis-builder#96 are generalizations of the analytic filter concept and are quite easy to implement btw.

@HviorForgeFlow HviorForgeFlow force-pushed the 11.0-account_move_line_budget branch 2 times, most recently from 37d030a to c0924cc Compare March 26, 2019 16:13
],
"data": [
"views/account_move_budget_line_views.xml",
"views/account_move_budget_views.xml",
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hveficent can you add here the link to /security/ir.model.access.csv?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @jbeficent

@JordiBForgeFlow JordiBForgeFlow force-pushed the 11.0-account_move_line_budget branch 2 times, most recently from 35f070a to 2613265 Compare June 21, 2019 12:11
@HviorForgeFlow
Copy link
Member

@jbeficent I would like to move module related with mis-builder to https://github.com/OCA/mis-builder-contrib in order to avoid dependence conflicts on this repo.

@JordiBForgeFlow
Copy link
Sponsor Member Author

JordiBForgeFlow commented Jul 15, 2019 via email

@HviorForgeFlow
Copy link
Member

ping @mreficent @jbeficent @aheficent @lreficent @ageficent

Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you create account move budget line without specifying date the following error pops up.

image

I think it may be due to the _order = "date desc"

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test only

@fclementic2c
Copy link
Member

just tested it.
All good 👍
bravo

@fclementic2c
Copy link
Member

Can I know what are the plans on this this regarding v12 ?

@HviorForgeFlow
Copy link
Member

The idea is move it forward asap

@JordiBForgeFlow
Copy link
Sponsor Member Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 11.0-ocabot-merge-pr-789-by-jbeficent-bump-no, awaiting test results.

@JordiBForgeFlow
Copy link
Sponsor Member Author

@ageficent can you migrate it to v12?

@OCA-git-bot OCA-git-bot merged commit f826ac9 into OCA:11.0 Jul 16, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b4d915a. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

OCA-git-bot added a commit that referenced this pull request Jul 16, 2019
Signed-off-by jbeficent
@MiquelRForgeFlow MiquelRForgeFlow deleted the 11.0-account_move_line_budget branch July 17, 2019 10:21
@AdriaGForgeFlow
Copy link
Contributor

@ageficent can you migrate it to v12?

On it 👍

@kittiu
Copy link
Member

kittiu commented Jul 31, 2019

@jbeficent
cc @sbidoul , @pedrobaeza

To relate with OCA/mis-builder#217

Do I understand correctly that, account_move_budget_line is intended to used as alternate source in replacement of account.move.line (which is normally use as actual budget) ?

From what I see, it is for user to register the amount manually, regardless of any document transaction, right?

I am thinking about extending this account_move_budget_line with type for both budget commit (PR/PO/EX) and budget actual (INV). For example, when confirm PO, auto create account_move_budget_line of type "po_commit". And when confirm INV, auto create account_move_budget_line of type "actual" (also create negative "po_commit").

Then, we can use only account_move_budget_line for budgeting reports and also budget control.

Just the rough idea. WDYT?

@JordiBForgeFlow
Copy link
Sponsor Member Author

@kittiu You are right. The account_move_budget_line is used as an alternate source. The account.move.line is the actual expense.

The original intent is for the user to enter the values manually. I understand that you want to establish rules to automate the account_move_budget_line creation. But I would propose this as part of sepate modules, as every business will certainly have different rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants