Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][FIX] account_move_fiscal_*: remove "store=True" #914

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Nov 25, 2019

It doesn't make sense to store a field that is related to a non-stored computed field.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove copy=False too

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge minor

@AaronHForgeFlow
Copy link
Contributor

Please forward port to 12

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-914-by-aheficent-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 26, 2019
Signed-off-by aheficent
@OCA-git-bot OCA-git-bot merged commit b432180 into OCA:11.0 Nov 26, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 10aa79f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants